public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: alexandre.sidorenko@hpe.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion
Date: Thu, 06 Oct 2016 01:19:50 -0400 (EDT)	[thread overview]
Message-ID: <20161006.011950.406052415167344815.davem@davemloft.net> (raw)
In-Reply-To: <2440068.EFRMUI8i5V@zbook>

From: Alex Sidorenko <alexandre.sidorenko@hpe.com>
Date: Wed, 05 Oct 2016 09:06:04 -0400

> Roundrobin runner of team driver uses 'unsigned int' variable to count the number of sent_packets.
> Later it is passed to a subroutine team_num_to_port_index(struct team *team, int num) as
> 'num' and when we reach MAXINT (2**31-1), 'num' becomes negative.
> 
> This leads to using incorrect hash-bucket for port lookup and as a result, packets are dropped. The fix
> consists of changing 'int num' to 'unsigned int num'. Testing of a fixed kernel shows that there
> is no packet drop anymore.
> 
> 
> Signed-off-by: Alex Sidorenko <alexandre.sidorenko@hpe.com>

This patch has been corrupted by your email client, for example it
has transformed TAB charactes into spaces.

Please fix this up, email a test patch to yourself, and only resubmit
this patch to the mailing list when you are able to successfully apply
the test patch you send to yourself.

Thanks.

      parent reply	other threads:[~2016-10-06  5:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 22:30 A bug in team driver Alex Sidorenko
2016-10-05  3:08 ` Eric Dumazet
2016-10-05 13:06   ` [PATCH net] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion Alex Sidorenko
2016-10-05 19:37     ` Eric Dumazet
2016-10-06  5:19     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161006.011950.406052415167344815.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexandre.sidorenko@hpe.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox