Netdev List
 help / color / mirror / Atom feed
* [PATCHv2 1/1] r8169: fix the typo in the comment
@ 2017-01-05  8:02 Zhu Yanjun
  2017-01-05 16:25 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Zhu Yanjun @ 2017-01-05  8:02 UTC (permalink / raw)
  To: nic_swsd, netdev; +Cc: Zhu Yanjun

>From the realtek data sheet, the PID0 should be bit 0.

Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
---
Change from v1 to v2:
 change the commit header. 

 drivers/net/ethernet/realtek/r8169.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 44389c9..8f1623b 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -696,7 +696,7 @@ enum rtl_tx_desc_bit_1 {
 enum rtl_rx_desc_bit {
 	/* Rx private */
 	PID1		= (1 << 18), /* Protocol ID bit 1/2 */
-	PID0		= (1 << 17), /* Protocol ID bit 2/2 */
+	PID0		= (1 << 17), /* Protocol ID bit 0/2 */
 
 #define RxProtoUDP	(PID1)
 #define RxProtoTCP	(PID0)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCHv2 1/1] r8169: fix the typo in the comment
@ 2017-01-05  7:54 yanjun.zhu
  0 siblings, 0 replies; 3+ messages in thread
From: yanjun.zhu @ 2017-01-05  7:54 UTC (permalink / raw)
  To: nic_swsd, netdev; +Cc: Zhu Yanjun

From: Zhu Yanjun <yanjun.zhu@oracle.com>

>From the realtek data sheet, the PID0 should be bit 0.

Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
---
Change from v1 to v2:
 change the commit header. 

 drivers/net/ethernet/realtek/r8169.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 44389c9..8f1623b 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -696,7 +696,7 @@ enum rtl_tx_desc_bit_1 {
 enum rtl_rx_desc_bit {
 	/* Rx private */
 	PID1		= (1 << 18), /* Protocol ID bit 1/2 */
-	PID0		= (1 << 17), /* Protocol ID bit 2/2 */
+	PID0		= (1 << 17), /* Protocol ID bit 0/2 */
 
 #define RxProtoUDP	(PID1)
 #define RxProtoTCP	(PID0)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-05 16:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-05  8:02 [PATCHv2 1/1] r8169: fix the typo in the comment Zhu Yanjun
2017-01-05 16:25 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2017-01-05  7:54 yanjun.zhu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox