Netdev List
 help / color / mirror / Atom feed
From: Michael Chan <michael.chan@broadcom.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: [PATCH net 0/3] bnxt_en: Fix RTNL lock usage in bnxt_sp_task().
Date: Wed, 25 Jan 2017 02:55:06 -0500	[thread overview]
Message-ID: <1485330909-12037-1-git-send-email-michael.chan@broadcom.com> (raw)

There are 2 function calls from bnxt_sp_task() that have buggy RTNL
usage.  These 2 functions take RTNL lock under some conditions, but
some callers (such as open, ethtool) have already taken RTNL.  These
3 patches fix the issue by making it clear that callers must take
RTNL.  If the caller is bnxt_sp_task() which does not automatically
take RTNL, we add a common scheme for bnxt_sp_task() to call these
functions properly under RTNL.


Michael Chan (3):
  bnxt_en: Fix bnxt_reset() in the slow path task.
  bnxt_en: Fix RTNL lock usage on bnxt_update_link().
  bnxt_en: Fix RTNL lock usage on bnxt_get_port_module_status().

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 78 ++++++++++++++++++-------------
 1 file changed, 46 insertions(+), 32 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2017-01-25  7:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25  7:55 Michael Chan [this message]
2017-01-25  7:55 ` [PATCH net 1/3] bnxt_en: Fix bnxt_reset() in the slow path task Michael Chan
2017-01-25  7:55 ` [PATCH net 2/3] bnxt_en: Fix RTNL lock usage on bnxt_update_link() Michael Chan
2017-01-25  7:55 ` [PATCH net 3/3] bnxt_en: Fix RTNL lock usage on bnxt_get_port_module_status() Michael Chan
2017-01-25 18:27 ` [PATCH net 0/3] bnxt_en: Fix RTNL lock usage in bnxt_sp_task() David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485330909-12037-1-git-send-email-michael.chan@broadcom.com \
    --to=michael.chan@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox