* [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll()
@ 2017-05-19 7:18 Konstantin Khlebnikov
2017-05-19 18:34 ` Cong Wang
2017-05-27 1:21 ` Brown, Aaron F
0 siblings, 2 replies; 4+ messages in thread
From: Konstantin Khlebnikov @ 2017-05-19 7:18 UTC (permalink / raw)
To: netdev, intel-wired-lan, Jeff Kirsher
Cc: Dave Jones, WANG Cong, David S. Miller, Sabrina Dubroca
Replace disable_irq() which waits for threaded irq handlers with
disable_hardirq() which waits only for hardirq part.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Fixes: 311191297125 ("e1000: use disable_hardirq() for e1000_netpoll()")
---
drivers/net/ethernet/intel/e1000e/netdev.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index b3679728caac..7f185f481b12 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -6733,20 +6733,20 @@ static irqreturn_t e1000_intr_msix(int __always_unused irq, void *data)
vector = 0;
msix_irq = adapter->msix_entries[vector].vector;
- disable_irq(msix_irq);
- e1000_intr_msix_rx(msix_irq, netdev);
+ if (disable_hardirq(msix_irq))
+ e1000_intr_msix_rx(msix_irq, netdev);
enable_irq(msix_irq);
vector++;
msix_irq = adapter->msix_entries[vector].vector;
- disable_irq(msix_irq);
- e1000_intr_msix_tx(msix_irq, netdev);
+ if (disable_hardirq(msix_irq))
+ e1000_intr_msix_tx(msix_irq, netdev);
enable_irq(msix_irq);
vector++;
msix_irq = adapter->msix_entries[vector].vector;
- disable_irq(msix_irq);
- e1000_msix_other(msix_irq, netdev);
+ if (disable_hardirq(msix_irq))
+ e1000_msix_other(msix_irq, netdev);
enable_irq(msix_irq);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll()
2017-05-19 7:18 [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll() Konstantin Khlebnikov
@ 2017-05-19 18:34 ` Cong Wang
2017-05-23 15:43 ` [Intel-wired-lan] " Neftin, Sasha
2017-05-27 1:21 ` Brown, Aaron F
1 sibling, 1 reply; 4+ messages in thread
From: Cong Wang @ 2017-05-19 18:34 UTC (permalink / raw)
To: Konstantin Khlebnikov
Cc: Linux Kernel Network Developers, intel-wired-lan, Jeff Kirsher,
Dave Jones, David S. Miller, Sabrina Dubroca, Thomas Gleixner
On Fri, May 19, 2017 at 12:18 AM, Konstantin Khlebnikov
<khlebnikov@yandex-team.ru> wrote:
> Replace disable_irq() which waits for threaded irq handlers with
> disable_hardirq() which waits only for hardirq part.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Fixes: 311191297125 ("e1000: use disable_hardirq() for e1000_netpoll()")
Thomas had a similar patch, I don't know why he never sends it
out formally. Anyway,
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-wired-lan] [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll()
2017-05-19 18:34 ` Cong Wang
@ 2017-05-23 15:43 ` Neftin, Sasha
0 siblings, 0 replies; 4+ messages in thread
From: Neftin, Sasha @ 2017-05-23 15:43 UTC (permalink / raw)
To: Cong Wang, Konstantin Khlebnikov
Cc: Dave Jones, Sabrina Dubroca, Linux Kernel Network Developers,
intel-wired-lan, Thomas Gleixner, David S. Miller
On 5/19/2017 21:34, Cong Wang wrote:
> On Fri, May 19, 2017 at 12:18 AM, Konstantin Khlebnikov
> <khlebnikov@yandex-team.ru> wrote:
>> Replace disable_irq() which waits for threaded irq handlers with
>> disable_hardirq() which waits only for hardirq part.
>>
>> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
>> Fixes: 311191297125 ("e1000: use disable_hardirq() for e1000_netpoll()")
> Thomas had a similar patch, I don't know why he never sends it
> out formally. Anyway,
>
> Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Ack. Let's pick up this patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll()
2017-05-19 7:18 [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll() Konstantin Khlebnikov
2017-05-19 18:34 ` Cong Wang
@ 2017-05-27 1:21 ` Brown, Aaron F
1 sibling, 0 replies; 4+ messages in thread
From: Brown, Aaron F @ 2017-05-27 1:21 UTC (permalink / raw)
To: Konstantin Khlebnikov, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, Kirsher, Jeffrey T
Cc: Dave Jones, WANG Cong, David S. Miller, Sabrina Dubroca
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Konstantin Khlebnikov
> Sent: Friday, May 19, 2017 12:19 AM
> To: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; Kirsher, Jeffrey
> T <jeffrey.t.kirsher@intel.com>
> Cc: Dave Jones <davej@codemonkey.org.uk>; WANG Cong
> <xiyou.wangcong@gmail.com>; David S. Miller <davem@davemloft.net>;
> Sabrina Dubroca <sd@queasysnail.net>
> Subject: [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in
> e1000_netpoll()
>
> Replace disable_irq() which waits for threaded irq handlers with
> disable_hardirq() which waits only for hardirq part.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Fixes: 311191297125 ("e1000: use disable_hardirq() for e1000_netpoll()")
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-27 1:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-19 7:18 [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll() Konstantin Khlebnikov
2017-05-19 18:34 ` Cong Wang
2017-05-23 15:43 ` [Intel-wired-lan] " Neftin, Sasha
2017-05-27 1:21 ` Brown, Aaron F
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox