* [PATCH net-next] vxlan: dont migrate permanent fdb entries during learn
@ 2017-06-11 22:51 Roopa Prabhu
2017-06-11 23:04 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Roopa Prabhu @ 2017-06-11 22:51 UTC (permalink / raw)
To: davem; +Cc: netdev, jbenc, hannes, nicolas.dichtel, nikolay
From: Roopa Prabhu <roopa@cumulusnetworks.com>
This patch fixes vxlan_snoop to not move permanent fdb entries
on learn events. This is consistent with the bridge fdb
handling of permanent entries.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 7cb21a0..e045c34 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -970,7 +970,7 @@ static bool vxlan_snoop(struct net_device *dev,
return false;
/* Don't migrate static entries, drop packets */
- if (f->state & NUD_NOARP)
+ if (f->state & (NUD_PERMANENT | NUD_NOARP))
return true;
if (net_ratelimit())
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] vxlan: dont migrate permanent fdb entries during learn
2017-06-11 22:51 [PATCH net-next] vxlan: dont migrate permanent fdb entries during learn Roopa Prabhu
@ 2017-06-11 23:04 ` David Miller
2017-06-11 23:26 ` Roopa Prabhu
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2017-06-11 23:04 UTC (permalink / raw)
To: roopa; +Cc: netdev, jbenc, hannes, nicolas.dichtel, nikolay
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Sun, 11 Jun 2017 15:51:22 -0700
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> This patch fixes vxlan_snoop to not move permanent fdb entries
> on learn events. This is consistent with the bridge fdb
> handling of permanent entries.
>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Is there an appropriate Fixes: tag by chance?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] vxlan: dont migrate permanent fdb entries during learn
2017-06-11 23:04 ` David Miller
@ 2017-06-11 23:26 ` Roopa Prabhu
0 siblings, 0 replies; 3+ messages in thread
From: Roopa Prabhu @ 2017-06-11 23:26 UTC (permalink / raw)
To: David Miller
Cc: netdev@vger.kernel.org, Jiri Benc, hannes@stressinduktion.org,
Nicolas Dichtel, Nikolay Aleksandrov
On Sun, Jun 11, 2017 at 4:04 PM, David Miller <davem@davemloft.net> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> Date: Sun, 11 Jun 2017 15:51:22 -0700
>
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> This patch fixes vxlan_snoop to not move permanent fdb entries
>> on learn events. This is consistent with the bridge fdb
>> handling of permanent entries.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Is there an appropriate Fixes: tag by chance?
Just checked history. It has been that way since beginning of time.
Initial vxlan implementation (year 2012) allowed migration of any
entry via learn. A 2013 commit 26a41ae60438 ("vxlan: only migrate
dynamic FDB entries") tried to fix it, but it added a check for static
entries only (NUD_NOARP) and missed permanent entries (NUD_PERMANENT).
I think we can add:
Fixes: 26a41ae60438 ("vxlan: only migrate dynamic FDB entries")
I can re-spin with this Fixes tag.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-11 23:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-11 22:51 [PATCH net-next] vxlan: dont migrate permanent fdb entries during learn Roopa Prabhu
2017-06-11 23:04 ` David Miller
2017-06-11 23:26 ` Roopa Prabhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox