Netdev List
 help / color / mirror / Atom feed
* [PATCH 10/35] net: usb: catc: constify usb_device_id and fix space before '[' error
@ 2017-08-08 15:58 Arvind Yadav
  2017-08-08 15:58 ` [PATCH 11/35] net: usb: cdc-phonet: constify usb_device_id Arvind Yadav
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-08-08 15:58 UTC (permalink / raw)
  To: kvalo; +Cc: linux-kernel, netdev, linux-usb

usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Fix checkpatch.pl error:
ERROR: space prohibited before open square bracket '['.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/net/usb/catc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c
index fce92f0..01cd17e 100644
--- a/drivers/net/usb/catc.c
+++ b/drivers/net/usb/catc.c
@@ -961,7 +961,7 @@ static void catc_disconnect(struct usb_interface *intf)
  * Module functions and tables.
  */
 
-static struct usb_device_id catc_id_table [] = {
+static const struct usb_device_id catc_id_table[] = {
 	{ USB_DEVICE(0x0423, 0xa) },	/* CATC Netmate, Belkin F5U011 */
 	{ USB_DEVICE(0x0423, 0xc) },	/* CATC Netmate II, Belkin F5U111 */
 	{ USB_DEVICE(0x08d1, 0x1) },	/* smartBridges smartNIC */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-08-08 15:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08 15:58 [PATCH 10/35] net: usb: catc: constify usb_device_id and fix space before '[' error Arvind Yadav
2017-08-08 15:58 ` [PATCH 11/35] net: usb: cdc-phonet: constify usb_device_id Arvind Yadav
2017-08-08 15:58 ` [PATCH 12/35] net: usb: ipheth: " Arvind Yadav
2017-08-08 15:58 ` [PATCH 13/35] net: usb: kaweth: " Arvind Yadav
2017-08-08 15:58 ` [PATCH 14/35] net: usb: r8152: " Arvind Yadav

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox