* [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id
@ 2017-08-08 16:05 Arvind Yadav
2017-08-09 4:09 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-08 16:05 UTC (permalink / raw)
To: kvalo, Larry.Finger, chaoming_li; +Cc: linux-kernel, netdev, linux-wireless
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
index 96c923b..e673bc2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
@@ -275,7 +275,7 @@ static struct rtl_hal_cfg rtl92cu_hal_cfg = {
#define USB_VENDER_ID_REALTEK 0x0bda
/* 2010-10-19 DID_USB_V3.4 */
-static struct usb_device_id rtl8192c_usb_ids[] = {
+static const struct usb_device_id rtl8192c_usb_ids[] = {
/*=== Realtek demoboard ===*/
/* Default ID */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id
2017-08-08 16:05 [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id Arvind Yadav
@ 2017-08-09 4:09 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2017-08-09 4:09 UTC (permalink / raw)
To: Arvind Yadav, kvalo, chaoming_li; +Cc: linux-kernel, netdev, linux-wireless
On 08/08/2017 11:05 AM, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> index 96c923b..e673bc2 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> @@ -275,7 +275,7 @@ static struct rtl_hal_cfg rtl92cu_hal_cfg = {
> #define USB_VENDER_ID_REALTEK 0x0bda
>
> /* 2010-10-19 DID_USB_V3.4 */
> -static struct usb_device_id rtl8192c_usb_ids[] = {
> +static const struct usb_device_id rtl8192c_usb_ids[] = {
>
> /*=== Realtek demoboard ===*/
> /* Default ID */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-09 4:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08 16:05 [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id Arvind Yadav
2017-08-09 4:09 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox