* [PATCH] net/sched/hfsc: allocate tcf block for hfsc root class
@ 2017-08-10 9:31 Konstantin Khlebnikov
2017-08-11 20:29 ` Cong Wang
2017-08-11 21:31 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Konstantin Khlebnikov @ 2017-08-10 9:31 UTC (permalink / raw)
To: netdev, Jiri Pirko, David S. Miller, Jamal Hadi Salim
Without this filters cannot be attached.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
---
net/sched/sch_hfsc.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index b52f74610dc7..3ad02bbe6903 100644
--- a/net/sched/sch_hfsc.c
+++ b/net/sched/sch_hfsc.c
@@ -1428,6 +1428,10 @@ hfsc_init_qdisc(struct Qdisc *sch, struct nlattr *opt)
return err;
q->eligible = RB_ROOT;
+ err = tcf_block_get(&q->root.block, &q->root.filter_list);
+ if (err)
+ goto err_tcf;
+
q->root.cl_common.classid = sch->handle;
q->root.refcnt = 1;
q->root.sched = q;
@@ -1447,6 +1451,10 @@ hfsc_init_qdisc(struct Qdisc *sch, struct nlattr *opt)
qdisc_watchdog_init(&q->watchdog, sch);
return 0;
+
+err_tcf:
+ qdisc_class_hash_destroy(&q->clhash);
+ return err;
}
static int
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/sched/hfsc: allocate tcf block for hfsc root class
2017-08-10 9:31 [PATCH] net/sched/hfsc: allocate tcf block for hfsc root class Konstantin Khlebnikov
@ 2017-08-11 20:29 ` Cong Wang
2017-08-11 21:31 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2017-08-11 20:29 UTC (permalink / raw)
To: Konstantin Khlebnikov
Cc: Linux Kernel Network Developers, Jiri Pirko, David S. Miller,
Jamal Hadi Salim
On Thu, Aug 10, 2017 at 2:31 AM, Konstantin Khlebnikov
<khlebnikov@yandex-team.ru> wrote:
> Without this filters cannot be attached.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
Looks good.
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/sched/hfsc: allocate tcf block for hfsc root class
2017-08-10 9:31 [PATCH] net/sched/hfsc: allocate tcf block for hfsc root class Konstantin Khlebnikov
2017-08-11 20:29 ` Cong Wang
@ 2017-08-11 21:31 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-08-11 21:31 UTC (permalink / raw)
To: khlebnikov; +Cc: netdev, jiri, jhs
From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Date: Thu, 10 Aug 2017 12:31:40 +0300
> Without this filters cannot be attached.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-11 21:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-10 9:31 [PATCH] net/sched/hfsc: allocate tcf block for hfsc root class Konstantin Khlebnikov
2017-08-11 20:29 ` Cong Wang
2017-08-11 21:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox