Netdev List
 help / color / mirror / Atom feed
From: Madalin Bucur <madalin.bucur@nxp.com>
To: <netdev@vger.kernel.org>, <davem@davemloft.net>
Cc: <f.fainelli@gmail.com>, <andrew@lunn.ch>,
	<vivien.didelot@savoirfairelinux.com>, <junote@outlook.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 0/5] adapt DPAA drivers for DSA
Date: Fri, 13 Oct 2017 17:50:07 +0300	[thread overview]
Message-ID: <1507906212-10076-1-git-send-email-madalin.bucur@nxp.com> (raw)

Junote Cai reported that he was not able to get a DSA setup involving the
DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node()
call in DSA setup. The initial attempt to fix this by adding of_node to the
platform device results in a second, failed, probing of the FMan MAC driver
against the new platform device created for the DPAA Ethernet driver.
Solve these issues by removing the of_node pointer from the platform device
and changing the net_dev dev to the of_device dev to ensure the DSA init
will be able to find the DPAA net_dev using of_find_net_device_by_node().
Several changes were required to enable this solution: refactoring the
adjust_link (also resulted in lesser, cleaner code) and renaming the fman
kernel modules to keep the legacy udev rules happy.

Changes in v2:

 - fix issue on error path in "dpaa_eth: change device used" patch
 - cleanup the dpaa_eth_probe() error paths

Madalin Bucur (5):
  fsl/fman: remove of_node
  dpaa_eth: move of_phy_connect() to the eth driver
  dpaa_eth: change device used
  dpaa_eth: cleanup dpaa_eth_probe() error paths
  fsl/fman: add dpaa in module names

 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 143 +++++++++++++------------
 drivers/net/ethernet/freescale/fman/Makefile   |  12 +--
 drivers/net/ethernet/freescale/fman/mac.c      | 135 ++++++-----------------
 drivers/net/ethernet/freescale/fman/mac.h      |   6 +-
 4 files changed, 119 insertions(+), 177 deletions(-)

-- 
2.1.0

             reply	other threads:[~2017-10-13 14:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 14:50 Madalin Bucur [this message]
2017-10-13 14:50 ` [PATCH v2 1/5] fsl/fman: remove of_node Madalin Bucur
2017-10-13 14:50 ` [PATCH v2 2/5] dpaa_eth: move of_phy_connect() to the eth driver Madalin Bucur
2017-10-15 18:33   ` Andrew Lunn
2017-10-16  4:26     ` Madalin-cristian Bucur
2017-10-13 14:50 ` [PATCH v2 3/5] dpaa_eth: change device used Madalin Bucur
2017-10-13 14:50 ` [PATCH v2 4/5] dpaa_eth: cleanup dpaa_eth_probe() error paths Madalin Bucur
2017-10-13 14:50 ` [PATCH v2 5/5] fsl/fman: add dpaa in module names Madalin Bucur
2017-10-13 17:39   ` Florian Fainelli
2017-10-16  3:15     ` Madalin-cristian Bucur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507906212-10076-1-git-send-email-madalin.bucur@nxp.com \
    --to=madalin.bucur@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=junote@outlook.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox