From: Florian Fainelli <f.fainelli@gmail.com>
To: madalin.bucur@nxp.com, netdev@vger.kernel.org, davem@davemloft.net
Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
junote@outlook.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] fsl/fman: add dpaa in module names
Date: Fri, 13 Oct 2017 10:39:08 -0700 [thread overview]
Message-ID: <ba387138-03e5-52df-dc5b-98c6c9d57be8@gmail.com> (raw)
In-Reply-To: <1507906212-10076-6-git-send-email-madalin.bucur@nxp.com>
On 10/13/2017 07:50 AM, Madalin Bucur wrote:
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
You should provide a line or two to explain why are you making this
change, it is to resolve modular build configurations?
> ---
> drivers/net/ethernet/freescale/fman/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/Makefile b/drivers/net/ethernet/freescale/fman/Makefile
> index 2c38119..4ae524a 100644
> --- a/drivers/net/ethernet/freescale/fman/Makefile
> +++ b/drivers/net/ethernet/freescale/fman/Makefile
> @@ -1,9 +1,9 @@
> subdir-ccflags-y += -I$(srctree)/drivers/net/ethernet/freescale/fman
>
> -obj-$(CONFIG_FSL_FMAN) += fsl_fman.o
> -obj-$(CONFIG_FSL_FMAN) += fsl_fman_port.o
> -obj-$(CONFIG_FSL_FMAN) += fsl_mac.o
> +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman.o
> +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman_port.o
> +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_mac.o
>
> -fsl_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o
> -fsl_fman_port-objs := fman_port.o
> -fsl_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o
> +fsl_dpaa_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o
> +fsl_dpaa_fman_port-objs := fman_port.o
> +fsl_dpaa_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o
>
--
Florian
next prev parent reply other threads:[~2017-10-13 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 14:50 [PATCH v2 0/5] adapt DPAA drivers for DSA Madalin Bucur
2017-10-13 14:50 ` [PATCH v2 1/5] fsl/fman: remove of_node Madalin Bucur
2017-10-13 14:50 ` [PATCH v2 2/5] dpaa_eth: move of_phy_connect() to the eth driver Madalin Bucur
2017-10-15 18:33 ` Andrew Lunn
2017-10-16 4:26 ` Madalin-cristian Bucur
2017-10-13 14:50 ` [PATCH v2 3/5] dpaa_eth: change device used Madalin Bucur
2017-10-13 14:50 ` [PATCH v2 4/5] dpaa_eth: cleanup dpaa_eth_probe() error paths Madalin Bucur
2017-10-13 14:50 ` [PATCH v2 5/5] fsl/fman: add dpaa in module names Madalin Bucur
2017-10-13 17:39 ` Florian Fainelli [this message]
2017-10-16 3:15 ` Madalin-cristian Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba387138-03e5-52df-dc5b-98c6c9d57be8@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=junote@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox