From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: netdev@vger.kernel.org,
Jesper Dangaard Brouer <brouer@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
dsahern@gmail.com, gospo@broadcom.com, bjorn.topel@intel.com,
michael.chan@broadcom.com
Subject: [bpf-next V4 PATCH 13/14] bpf: finally expose xdp_rxq_info to XDP bpf-programs
Date: Wed, 03 Jan 2018 11:26:14 +0100 [thread overview]
Message-ID: <151497517476.18176.6299242208330652860.stgit@firesoul> (raw)
In-Reply-To: <151497504273.18176.10177133999720101758.stgit@firesoul>
Now all XDP driver have been updated to setup xdp_rxq_info and assign
this to xdp_buff->rxq. Thus, it is now safe to enable access to some
of the xdp_rxq_info struct members.
This patch extend xdp_md and expose UAPI to userspace for
ingress_ifindex and rx_queue_index. Access happens via bpf
instruction rewrite, that load data directly from struct xdp_rxq_info.
* ingress_ifindex map to xdp_rxq_info->dev->ifindex
* rx_queue_index map to xdp_rxq_info->queue_index
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
---
include/uapi/linux/bpf.h | 3 +++
net/core/filter.c | 19 +++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index 69eabfcb9bdb..a6000a95d40e 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -899,6 +899,9 @@ struct xdp_md {
__u32 data;
__u32 data_end;
__u32 data_meta;
+ /* Below access go though struct xdp_rxq_info */
+ __u32 ingress_ifindex; /* rxq->dev->ifindex */
+ __u32 rx_queue_index; /* rxq->queue_index */
};
enum sk_action {
diff --git a/net/core/filter.c b/net/core/filter.c
index 130b842c3a15..acdb94c0e97f 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -4304,6 +4304,25 @@ static u32 xdp_convert_ctx_access(enum bpf_access_type type,
si->dst_reg, si->src_reg,
offsetof(struct xdp_buff, data_end));
break;
+ case offsetof(struct xdp_md, ingress_ifindex):
+ *insn++ = BPF_LDX_MEM(BPF_FIELD_SIZEOF(struct xdp_buff, rxq),
+ si->dst_reg, si->src_reg,
+ offsetof(struct xdp_buff, rxq));
+ *insn++ = BPF_LDX_MEM(BPF_FIELD_SIZEOF(struct xdp_rxq_info, dev),
+ si->dst_reg, si->dst_reg,
+ offsetof(struct xdp_rxq_info, dev));
+ *insn++ = BPF_LDX_MEM(BPF_W, si->dst_reg, si->dst_reg,
+ bpf_target_off(struct net_device,
+ ifindex, 4, target_size));
+ break;
+ case offsetof(struct xdp_md, rx_queue_index):
+ *insn++ = BPF_LDX_MEM(BPF_FIELD_SIZEOF(struct xdp_buff, rxq),
+ si->dst_reg, si->src_reg,
+ offsetof(struct xdp_buff, rxq));
+ *insn++ = BPF_LDX_MEM(BPF_W, si->dst_reg, si->dst_reg,
+ bpf_target_off(struct xdp_rxq_info,
+ queue_index, 4, target_size));
+ break;
}
return insn - insn_buf;
next prev parent reply other threads:[~2018-01-03 10:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 10:25 [bpf-next V4 PATCH 00/14] xdp: new XDP rx-queue info concept Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 01/14] xdp: base API for " Jesper Dangaard Brouer
2018-01-05 4:54 ` John Fastabend
2018-01-03 10:25 ` [bpf-next V4 PATCH 02/14] xdp/mlx5: setup xdp_rxq_info Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 03/14] i40e: " Jesper Dangaard Brouer
2018-01-05 4:17 ` [Intel-wired-lan] " John Fastabend
2018-01-03 10:25 ` [bpf-next V4 PATCH 04/14] ixgbe: " Jesper Dangaard Brouer
2018-01-05 4:13 ` [Intel-wired-lan] " John Fastabend
2018-01-03 10:25 ` [bpf-next V4 PATCH 05/14] xdp/qede: setup xdp_rxq_info and intro xdp_rxq_info_is_reg Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 06/14] mlx4: setup xdp_rxq_info Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 07/14] bnxt_en: " Jesper Dangaard Brouer
2018-01-05 4:35 ` Michael Chan
2018-01-03 10:25 ` [bpf-next V4 PATCH 08/14] nfp: " Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 09/14] thunderx: " Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 10/14] tun: " Jesper Dangaard Brouer
2018-01-03 10:26 ` [bpf-next V4 PATCH 11/14] virtio_net: " Jesper Dangaard Brouer
2018-01-03 10:26 ` [bpf-next V4 PATCH 12/14] xdp: generic XDP handling of xdp_rxq_info Jesper Dangaard Brouer
2018-01-03 10:26 ` Jesper Dangaard Brouer [this message]
2018-01-05 4:34 ` [bpf-next V4 PATCH 13/14] bpf: finally expose xdp_rxq_info to XDP bpf-programs John Fastabend
2018-01-06 0:54 ` Daniel Borkmann
2018-01-03 10:26 ` [bpf-next V4 PATCH 14/14] samples/bpf: program demonstrating access to xdp_rxq_info Jesper Dangaard Brouer
2018-01-05 23:59 ` [bpf-next V4 PATCH 00/14] xdp: new XDP rx-queue info concept Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151497517476.18176.6299242208330652860.stgit@firesoul \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=borkmann@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=gospo@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox