Netdev List
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
	Daniel Borkmann <borkmann@iogearbox.net>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: netdev@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	dsahern@gmail.com, gospo@broadcom.com, bjorn.topel@intel.com,
	michael.chan@broadcom.com
Subject: Re: [bpf-next V4 PATCH 13/14] bpf: finally expose xdp_rxq_info to XDP bpf-programs
Date: Thu, 4 Jan 2018 20:34:41 -0800	[thread overview]
Message-ID: <e20d408f-b869-537a-ff1e-9a3df9a58141@gmail.com> (raw)
In-Reply-To: <151497517476.18176.6299242208330652860.stgit@firesoul>

On 01/03/2018 02:26 AM, Jesper Dangaard Brouer wrote:
> Now all XDP driver have been updated to setup xdp_rxq_info and assign
> this to xdp_buff->rxq.  Thus, it is now safe to enable access to some
> of the xdp_rxq_info struct members.
> 
> This patch extend xdp_md and expose UAPI to userspace for
> ingress_ifindex and rx_queue_index.  Access happens via bpf
> instruction rewrite, that load data directly from struct xdp_rxq_info.
> 
> * ingress_ifindex map to xdp_rxq_info->dev->ifindex
> * rx_queue_index  map to xdp_rxq_info->queue_index
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
> ---

LGTM

Acked-by: John Fastabend <john.fastabend@gmail.com>

  reply	other threads:[~2018-01-05  4:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 10:25 [bpf-next V4 PATCH 00/14] xdp: new XDP rx-queue info concept Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 01/14] xdp: base API for " Jesper Dangaard Brouer
2018-01-05  4:54   ` John Fastabend
2018-01-03 10:25 ` [bpf-next V4 PATCH 02/14] xdp/mlx5: setup xdp_rxq_info Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 03/14] i40e: " Jesper Dangaard Brouer
2018-01-05  4:17   ` [Intel-wired-lan] " John Fastabend
2018-01-03 10:25 ` [bpf-next V4 PATCH 04/14] ixgbe: " Jesper Dangaard Brouer
2018-01-05  4:13   ` [Intel-wired-lan] " John Fastabend
2018-01-03 10:25 ` [bpf-next V4 PATCH 05/14] xdp/qede: setup xdp_rxq_info and intro xdp_rxq_info_is_reg Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 06/14] mlx4: setup xdp_rxq_info Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 07/14] bnxt_en: " Jesper Dangaard Brouer
2018-01-05  4:35   ` Michael Chan
2018-01-03 10:25 ` [bpf-next V4 PATCH 08/14] nfp: " Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 09/14] thunderx: " Jesper Dangaard Brouer
2018-01-03 10:25 ` [bpf-next V4 PATCH 10/14] tun: " Jesper Dangaard Brouer
2018-01-03 10:26 ` [bpf-next V4 PATCH 11/14] virtio_net: " Jesper Dangaard Brouer
2018-01-03 10:26 ` [bpf-next V4 PATCH 12/14] xdp: generic XDP handling of xdp_rxq_info Jesper Dangaard Brouer
2018-01-03 10:26 ` [bpf-next V4 PATCH 13/14] bpf: finally expose xdp_rxq_info to XDP bpf-programs Jesper Dangaard Brouer
2018-01-05  4:34   ` John Fastabend [this message]
2018-01-06  0:54   ` Daniel Borkmann
2018-01-03 10:26 ` [bpf-next V4 PATCH 14/14] samples/bpf: program demonstrating access to xdp_rxq_info Jesper Dangaard Brouer
2018-01-05 23:59 ` [bpf-next V4 PATCH 00/14] xdp: new XDP rx-queue info concept Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e20d408f-b869-537a-ff1e-9a3df9a58141@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@intel.com \
    --cc=borkmann@iogearbox.net \
    --cc=brouer@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=gospo@broadcom.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox