From: Gal Pressman <galp@mellanox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Gal Pressman <galp@mellanox.com>,
Ariel Elior <ariel.elior@cavium.com>
Subject: [PATCH net-next 5/6] bnx2x: Replace WARN_ONCE with netdev_WARN_ONCE
Date: Thu, 4 Jan 2018 16:56:02 +0200 [thread overview]
Message-ID: <1515077763-27991-6-git-send-email-galp@mellanox.com> (raw)
In-Reply-To: <1515077763-27991-1-git-send-email-galp@mellanox.com>
Use the more appropriate netdev_WARN_ONCE instead of WARN_ONCE macro.
Signed-off-by: Gal Pressman <galp@mellanox.com>
Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
Cc: Ariel Elior <ariel.elior@cavium.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
index 57eb26d..d7c98e8 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
@@ -738,8 +738,9 @@ static void bnx2x_gro_receive(struct bnx2x *bp, struct bnx2x_fastpath *fp,
bnx2x_gro_csum(bp, skb, bnx2x_gro_ipv6_csum);
break;
default:
- WARN_ONCE(1, "Error: FW GRO supports only IPv4/IPv6, not 0x%04x\n",
- be16_to_cpu(skb->protocol));
+ netdev_WARN_ONCE(bp->dev,
+ "Error: FW GRO supports only IPv4/IPv6, not 0x%04x\n",
+ be16_to_cpu(skb->protocol));
}
}
#endif
--
2.7.4
next prev parent reply other threads:[~2018-01-04 14:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 14:55 [PATCH net-next 0/6] Replace WARN_ONCE usages with netdev_WARN_ONCE Gal Pressman
2018-01-04 14:55 ` [PATCH net-next 1/6] net: Fix netdev_WARN_ONCE macro Gal Pressman
2018-01-05 18:35 ` David Miller
2018-01-07 9:31 ` Gal Pressman
2018-01-04 14:55 ` [PATCH net-next 2/6] net: No line break on netdev_WARN* formatting Gal Pressman
2018-01-04 14:56 ` [PATCH net-next 3/6] net/mlx5e: Replace WARN_ONCE with netdev_WARN_ONCE Gal Pressman
2018-01-04 14:56 ` [PATCH net-next 4/6] e1000: " Gal Pressman
2018-01-04 14:56 ` Gal Pressman [this message]
2018-01-04 14:56 ` [PATCH net-next 6/6] 8139cp: " Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515077763-27991-6-git-send-email-galp@mellanox.com \
--to=galp@mellanox.com \
--cc=ariel.elior@cavium.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox