From: Gal Pressman <galp@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, tariqt@mellanox.com, saeedm@mellanox.com
Subject: Re: [PATCH net-next 1/6] net: Fix netdev_WARN_ONCE macro
Date: Sun, 7 Jan 2018 11:31:48 +0200 [thread overview]
Message-ID: <40b65abb-9aac-21eb-a474-cd3d63c730e4@mellanox.com> (raw)
In-Reply-To: <20180105.133519.1602365963790420581.davem@davemloft.net>
On 05-Jan-18 20:35, David Miller wrote:
> From: Gal Pressman <galp@mellanox.com>
> Date: Thu, 4 Jan 2018 16:55:58 +0200
>
>> netdev_WARN_ONCE is broken (whoops..), fix it.
>
> You don't say how it is broken and how you are fixing that
> brokenness, and you must do this.
>
> Yes, if I stare at your patch for a few minutes I can see
> the missing "," but you could have saved everyone reviewing
> this patch (now and in the future) by writing a proper and
> complete commit message.
>
Thank you for reviewing,
I will fix the commit message and submit v2.
next prev parent reply other threads:[~2018-01-07 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 14:55 [PATCH net-next 0/6] Replace WARN_ONCE usages with netdev_WARN_ONCE Gal Pressman
2018-01-04 14:55 ` [PATCH net-next 1/6] net: Fix netdev_WARN_ONCE macro Gal Pressman
2018-01-05 18:35 ` David Miller
2018-01-07 9:31 ` Gal Pressman [this message]
2018-01-04 14:55 ` [PATCH net-next 2/6] net: No line break on netdev_WARN* formatting Gal Pressman
2018-01-04 14:56 ` [PATCH net-next 3/6] net/mlx5e: Replace WARN_ONCE with netdev_WARN_ONCE Gal Pressman
2018-01-04 14:56 ` [PATCH net-next 4/6] e1000: " Gal Pressman
2018-01-04 14:56 ` [PATCH net-next 5/6] bnx2x: " Gal Pressman
2018-01-04 14:56 ` [PATCH net-next 6/6] 8139cp: " Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40b65abb-9aac-21eb-a474-cd3d63c730e4@mellanox.com \
--to=galp@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox