* Re: [PATCH net-next] mlxsw: spectrum_kvdl: Make some functions static
2018-03-12 12:25 [PATCH net-next] mlxsw: spectrum_kvdl: Make some functions static Wei Yongjun
@ 2018-03-12 12:24 ` Jiri Pirko
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Pirko @ 2018-03-12 12:24 UTC (permalink / raw)
To: Wei Yongjun
Cc: Jiri Pirko, Ido Schimmel, rkadi Sharshevsky, netdev,
kernel-janitors
Mon, Mar 12, 2018 at 01:25:24PM CET, weiyongjun1@huawei.com wrote:
>Fixes the following sparse warnings:
>
>drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:371:5: warning:
> symbol 'mlxsw_sp_kvdl_single_occ_get' was not declared. Should it be static?
>drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:384:5: warning:
> symbol 'mlxsw_sp_kvdl_chunks_occ_get' was not declared. Should it be static?
>drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:397:5: warning:
> symbol 'mlxsw_sp_kvdl_large_chunks_occ_get' was not declared. Should it be static?
>
>Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH net-next] mlxsw: spectrum_kvdl: Make some functions static
@ 2018-03-12 12:25 Wei Yongjun
2018-03-12 12:24 ` Jiri Pirko
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-03-12 12:25 UTC (permalink / raw)
To: Jiri Pirko, Ido Schimmel, rkadi Sharshevsky
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warnings:
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:371:5: warning:
symbol 'mlxsw_sp_kvdl_single_occ_get' was not declared. Should it be static?
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:384:5: warning:
symbol 'mlxsw_sp_kvdl_chunks_occ_get' was not declared. Should it be static?
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:397:5: warning:
symbol 'mlxsw_sp_kvdl_large_chunks_occ_get' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
index 059eb32..4c9bff2 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
@@ -368,7 +368,7 @@ u64 mlxsw_sp_kvdl_occ_get(const struct mlxsw_sp *mlxsw_sp)
return occ;
}
-u64 mlxsw_sp_kvdl_single_occ_get(struct devlink *devlink)
+static u64 mlxsw_sp_kvdl_single_occ_get(struct devlink *devlink)
{
struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
struct mlxsw_sp *mlxsw_sp = mlxsw_core_driver_priv(mlxsw_core);
@@ -381,7 +381,7 @@ u64 mlxsw_sp_kvdl_single_occ_get(struct devlink *devlink)
return mlxsw_sp_kvdl_part_occ(part);
}
-u64 mlxsw_sp_kvdl_chunks_occ_get(struct devlink *devlink)
+static u64 mlxsw_sp_kvdl_chunks_occ_get(struct devlink *devlink)
{
struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
struct mlxsw_sp *mlxsw_sp = mlxsw_core_driver_priv(mlxsw_core);
@@ -394,7 +394,7 @@ u64 mlxsw_sp_kvdl_chunks_occ_get(struct devlink *devlink)
return mlxsw_sp_kvdl_part_occ(part);
}
-u64 mlxsw_sp_kvdl_large_chunks_occ_get(struct devlink *devlink)
+static u64 mlxsw_sp_kvdl_large_chunks_occ_get(struct devlink *devlink)
{
struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
struct mlxsw_sp *mlxsw_sp = mlxsw_core_driver_priv(mlxsw_core);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-12 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-12 12:25 [PATCH net-next] mlxsw: spectrum_kvdl: Make some functions static Wei Yongjun
2018-03-12 12:24 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox