* [PATCH net-next] tipc: tipc_node_create() can be static
@ 2018-03-26 14:33 Wei Yongjun
2018-03-26 14:45 ` Jon Maloy
2018-03-27 14:50 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2018-03-26 14:33 UTC (permalink / raw)
To: Jon Maloy, Ying Xue; +Cc: Wei Yongjun, netdev, tipc-discussion, kernel-janitors
Fixes the following sparse warning:
net/tipc/node.c:336:18: warning:
symbol 'tipc_node_create' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/tipc/node.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/tipc/node.c b/net/tipc/node.c
index 4a95c8c..4fb4327 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -333,8 +333,8 @@ static void tipc_node_write_unlock(struct tipc_node *n)
}
}
-struct tipc_node *tipc_node_create(struct net *net, u32 addr,
- u8 *peer_id, u16 capabilities)
+static struct tipc_node *tipc_node_create(struct net *net, u32 addr,
+ u8 *peer_id, u16 capabilities)
{
struct tipc_net *tn = net_generic(net, tipc_net_id);
struct tipc_node *n, *temp_node;
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH net-next] tipc: tipc_node_create() can be static
2018-03-26 14:33 [PATCH net-next] tipc: tipc_node_create() can be static Wei Yongjun
@ 2018-03-26 14:45 ` Jon Maloy
2018-03-27 14:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jon Maloy @ 2018-03-26 14:45 UTC (permalink / raw)
To: Wei Yongjun, Ying Xue
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
kernel-janitors@vger.kernel.org
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Thanks
///jon
> -----Original Message-----
> From: Wei Yongjun [mailto:weiyongjun1@huawei.com]
> Sent: Monday, March 26, 2018 10:33
> To: Jon Maloy <jon.maloy@ericsson.com>; Ying Xue
> <ying.xue@windriver.com>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>; netdev@vger.kernel.org;
> tipc-discussion@lists.sourceforge.net; kernel-janitors@vger.kernel.org
> Subject: [PATCH net-next] tipc: tipc_node_create() can be static
>
> Fixes the following sparse warning:
>
> net/tipc/node.c:336:18: warning:
> symbol 'tipc_node_create' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> net/tipc/node.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/tipc/node.c b/net/tipc/node.c index 4a95c8c..4fb4327 100644
> --- a/net/tipc/node.c
> +++ b/net/tipc/node.c
> @@ -333,8 +333,8 @@ static void tipc_node_write_unlock(struct tipc_node
> *n)
> }
> }
>
> -struct tipc_node *tipc_node_create(struct net *net, u32 addr,
> - u8 *peer_id, u16 capabilities)
> +static struct tipc_node *tipc_node_create(struct net *net, u32 addr,
> + u8 *peer_id, u16 capabilities)
> {
> struct tipc_net *tn = net_generic(net, tipc_net_id);
> struct tipc_node *n, *temp_node;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] tipc: tipc_node_create() can be static
2018-03-26 14:33 [PATCH net-next] tipc: tipc_node_create() can be static Wei Yongjun
2018-03-26 14:45 ` Jon Maloy
@ 2018-03-27 14:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-27 14:50 UTC (permalink / raw)
To: weiyongjun1; +Cc: kernel-janitors, tipc-discussion, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Mon, 26 Mar 2018 14:33:13 +0000
> Fixes the following sparse warning:
>
> net/tipc/node.c:336:18: warning:
> symbol 'tipc_node_create' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-27 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-26 14:33 [PATCH net-next] tipc: tipc_node_create() can be static Wei Yongjun
2018-03-26 14:45 ` Jon Maloy
2018-03-27 14:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox