From: Camelia Groza <camelia.groza@nxp.com>
To: andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Camelia Groza <camelia.groza@nxp.com>
Subject: [PATCH] net: phy: use generic clause 45 autonegotiation done
Date: Wed, 18 Jul 2018 16:12:15 +0300 [thread overview]
Message-ID: <1531919535-20269-1-git-send-email-camelia.groza@nxp.com> (raw)
Only Clause 22 PHYs can use genphy_aneg_done(). Use
genphy_c45_aneg_done() for PHYs that implement Clause 45 without
the Clause 22 register set.
This change follows the model of phy_restart_aneg() which
differentiates between the two implementations in a similar way.
Fixes: 41408ad519f7 ("net: phy: avoid genphy_aneg_done() for PHYs without clause 22 support")
Signed-off-by: Camelia Groza <camelia.groza@nxp.com>
---
drivers/net/phy/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 537297d..4fcc703 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -151,7 +151,7 @@ int phy_aneg_done(struct phy_device *phydev)
* implement Clause 22 registers
*/
if (phydev->is_c45 && !(phydev->c45_ids.devices_in_package & BIT(0)))
- return -EINVAL;
+ return genphy_c45_aneg_done(phydev);
return genphy_aneg_done(phydev);
}
--
1.9.1
next reply other threads:[~2018-07-18 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 13:12 Camelia Groza [this message]
2018-07-18 14:39 ` [PATCH] net: phy: use generic clause 45 autonegotiation done Andrew Lunn
2018-07-19 12:47 ` Camelia Alexandra Groza
2018-07-19 12:56 ` Russell King - ARM Linux
2018-07-19 14:49 ` Andrew Lunn
2018-07-23 15:14 ` Camelia Alexandra Groza
2018-07-27 13:41 ` Camelia Alexandra Groza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531919535-20269-1-git-send-email-camelia.groza@nxp.com \
--to=camelia.groza@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox