From: Marco Berizzi <pupilla@libero.it>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388 hfsc_dequeue+0x319/0x350 [sch_hfsc]
Date: Thu, 22 Mar 2018 15:12:49 +0100 (CET) [thread overview]
Message-ID: <15688407.84941.1521727969769@mail.libero.it> (raw)
In-Reply-To: <11d36e94-0b07-425d-78d1-dd41b60a586f@mojatatu.com>
Il 19 marzo 2018 alle 11.07 Jamal Hadi Salim <jhs@mojatatu.com> ha scritto:
>
> On 18-03-15 08:48 PM, Cong Wang wrote:
>
> > On Wed, Mar 14, 2018 at 1:10 AM, Marco Berizzi <pupilla@libero.it> wrote:
> >
> > > > Il 9 marzo 2018 alle 0.14 Cong Wang <xiyou.wangcong@gmail.com> ha scritto:
> > > >
> > > > On Thu, Mar 8, 2018 at 8:02 AM, Marco Berizzi <pupilla@libero.it> wrote:
> > > >
> > > > > > Marco Berizzi wrote:
> > > > > >
> > > > > > Hello everyone,
> > > > > >
> > > > > > Yesterday I got this error on a slackware linux 4.16-rc4 system
> > > > > > running as a traffic shaping gateway and netfilter nat.
> > > > > > The error has been arisen after a partial ISP network outage,
> > > > > > so unfortunately it will not trivial for me to reproduce it again.
> > > > >
> > > > > Hello everyone,
> > > > >
> > > > > I'm getting this error twice/day, so fortunately I'm able to
> > > > > reproduce it.
> > > >
> > > > IIRC, there was a patch for this, but it got lost...
> > > >
> > > > I will take a look anyway.
> > >
> > > ok, thanks for the response. Let me know when there will be a patch
> > > available to test.
> >
> > It has been reported here:
> > https://bugzilla.kernel.org/show_bug.cgi?id=109581
> >
> > And there is a workaround from Konstantin:
> > https://patchwork.ozlabs.org/patch/803885/
> >
> > Unfortunately I don't think that is a real fix, we probably need to
> > fix HFSC itself rather than just workaround the qlen==0. It is not
> > trivial since HFSC implementation is not easy to understand.
> > Maybe Jamal knows better than me.
>
> Sorry for the latency - I looked at this on the plane and it is very
> specific to fq/codel. It is not clear to me why codel needs this but
> i note it has been there from the initial commit and from that
> perspective the patch looks reasonable. In any case:
> Punting it to Eric (on Cc).
Hello everyone,
just for ask: it there any luck to get this patch before 4.16 final?
next prev parent reply other threads:[~2018-03-22 14:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 16:58 WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388 hfsc_dequeue+0x319/0x350 [sch_hfsc] Marco Berizzi
2018-03-08 16:02 ` Marco Berizzi
2018-03-08 23:14 ` Cong Wang
2018-03-14 8:10 ` Marco Berizzi
2018-03-16 0:48 ` Cong Wang
2018-03-19 10:07 ` Jamal Hadi Salim
2018-03-22 14:12 ` Marco Berizzi [this message]
2018-04-06 10:53 ` Marco Berizzi
2018-06-05 6:39 ` Marco Berizzi
2018-06-18 19:28 ` Cong Wang
2018-06-19 11:42 ` Marco Berizzi
2018-06-20 7:00 ` Marco Berizzi
2018-06-20 23:00 ` Cong Wang
2018-06-22 11:05 ` Marco Berizzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15688407.84941.1521727969769@mail.libero.it \
--to=pupilla@libero.it \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox