From: Alexander Duyck <alexander.duyck@gmail.com>
To: mkubecek@suse.cz, netdev@vger.kernel.org
Subject: [ethtool PATCH] ethtool: Set mask correctly for dumping advertised FEC modes
Date: Mon, 15 Nov 2021 14:52:54 -0800 [thread overview]
Message-ID: <163701677432.25599.14085739652121434612.stgit@localhost.localdomain> (raw)
From: Alexander Duyck <alexanderduyck@fb.com>
Set the "mask" value to false when dumping the advertised FEC modes.
The advertised values are stored in the value field, while the supported
values are what is stored in the mask.
Without this change the supported value is displayed for both the supported
and advertised modes resulting in the advertised value being ignored.
Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>
---
netlink/settings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/netlink/settings.c b/netlink/settings.c
index c4f5d61923aa..ff1e783d099c 100644
--- a/netlink/settings.c
+++ b/netlink/settings.c
@@ -402,7 +402,7 @@ static int dump_our_modes(struct nl_context *nlctx, const struct nlattr *attr)
return ret;
printf("\tAdvertised auto-negotiation: %s\n", autoneg ? "Yes" : "No");
- ret = dump_link_modes(nlctx, attr, true, LM_CLASS_FEC,
+ ret = dump_link_modes(nlctx, attr, false, LM_CLASS_FEC,
"Advertised FEC modes: ", " ", "\n",
"Not reported");
return ret;
next reply other threads:[~2021-11-16 0:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 22:52 Alexander Duyck [this message]
2021-11-21 23:20 ` [ethtool PATCH] ethtool: Set mask correctly for dumping advertised FEC modes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163701677432.25599.14085739652121434612.stgit@localhost.localdomain \
--to=alexander.duyck@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox