[ethtool PATCH] ethtool: Set mask correctly for dumping advertised FEC modes

[ethtool PATCH] ethtool: Set mask correctly for dumping advertised FEC modes

[Alexander Duyck]

From: Alexander Duyck <alexanderduyck@fb.com>

Set the "mask" value to false when dumping the advertised FEC modes.
The advertised values are stored in the value field, while the supported
values are what is stored in the mask.

Without this change the supported value is displayed for both the supported
and advertised modes resulting in the advertised value being ignored.

Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>
---
 netlink/settings.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/settings.c b/netlink/settings.c
index c4f5d61923aa..ff1e783d099c 100644
--- a/netlink/settings.c
+++ b/netlink/settings.c
@@ -402,7 +402,7 @@ static int dump_our_modes(struct nl_context *nlctx, const struct nlattr *attr)
 		return ret;
 	printf("\tAdvertised auto-negotiation: %s\n", autoneg ? "Yes" : "No");
 
-	ret = dump_link_modes(nlctx, attr, true, LM_CLASS_FEC,
+	ret = dump_link_modes(nlctx, attr, false, LM_CLASS_FEC,
 			      "Advertised FEC modes: ", " ", "\n",
 			      "Not reported");
 	return ret;

Re: [ethtool PATCH] ethtool: Set mask correctly for dumping advertised FEC modes

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to ethtool/ethtool.git (master)
by Michal Kubecek <mkubecek@suse.cz>:

On Mon, 15 Nov 2021 14:52:54 -0800 you wrote:
> From: Alexander Duyck <alexanderduyck@fb.com>
> 
> Set the "mask" value to false when dumping the advertised FEC modes.
> The advertised values are stored in the value field, while the supported
> values are what is stored in the mask.
> 
> Without this change the supported value is displayed for both the supported
> and advertised modes resulting in the advertised value being ignored.
> 
> [...]

Here is the summary with links:
  - [ethtool] ethtool: Set mask correctly for dumping advertised FEC modes
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=50fdaec68feb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html