* [PATCH net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()
@ 2022-05-31 12:10 Dan Carpenter
2022-06-01 6:03 ` Toshiaki Makita
2022-06-01 13:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-05-31 12:10 UTC (permalink / raw)
To: Jamal Hadi Salim, Toshiaki Makita
Cc: Cong Wang, Jiri Pirko, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Paul Blakey, Pablo Neira Ayuso,
netdev, kernel-janitors
The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return
false on failure. It should not return negatives because that means
succes/true.
Fixes: fcb6aa86532c ("act_ct: Support GRE offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
net/sched/act_ct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
index 8af9d6e5ba61..e013253b10d1 100644
--- a/net/sched/act_ct.c
+++ b/net/sched/act_ct.c
@@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb,
break;
#endif
default:
- return -1;
+ return false;
}
if (ip6h->hop_limit <= 1)
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()
2022-05-31 12:10 [PATCH net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6() Dan Carpenter
@ 2022-06-01 6:03 ` Toshiaki Makita
2022-06-01 13:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Toshiaki Makita @ 2022-06-01 6:03 UTC (permalink / raw)
To: Dan Carpenter, Jamal Hadi Salim
Cc: Cong Wang, Jiri Pirko, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Paul Blakey, Pablo Neira Ayuso,
netdev, kernel-janitors
On 2022/05/31 21:10, Dan Carpenter wrote:
> The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return
> false on failure. It should not return negatives because that means
> succes/true.
>
> Fixes: fcb6aa86532c ("act_ct: Support GRE offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you!
Acked-by: Toshiaki Makita <toshiaki.makita1@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()
2022-05-31 12:10 [PATCH net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6() Dan Carpenter
2022-06-01 6:03 ` Toshiaki Makita
@ 2022-06-01 13:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-06-01 13:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: jhs, toshiaki.makita1, xiyou.wangcong, jiri, davem, edumazet,
kuba, pabeni, paulb, pablo, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 31 May 2022 15:10:05 +0300 you wrote:
> The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return
> false on failure. It should not return negatives because that means
> succes/true.
>
> Fixes: fcb6aa86532c ("act_ct: Support GRE offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> [...]
Here is the summary with links:
- [net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()
https://git.kernel.org/netdev/net/c/86360030cc51
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-01 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-31 12:10 [PATCH net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6() Dan Carpenter
2022-06-01 6:03 ` Toshiaki Makita
2022-06-01 13:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox