* [PATCH] dpaa2-eth: trace the allocated address instead of page struct
@ 2022-08-10 23:29 Chen Lin
2022-08-11 14:41 ` Ioana Ciornei
0 siblings, 1 reply; 4+ messages in thread
From: Chen Lin @ 2022-08-10 23:29 UTC (permalink / raw)
To: ioana.ciornei
Cc: davem, edumazet, kuba, pabeni, netdev, linux-kernel, yi.liu,
Chen Lin, Chen Lin
Follow the commit 27c874867c4(dpaa2-eth: Use a single page per Rx buffer),
we should trace the allocated address instead of page struct.
Signed-off-by: Chen Lin <chen.lin5@zte.com.cn>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index cd9ec8052..75d515726 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -1660,8 +1660,8 @@ static int dpaa2_eth_add_bufs(struct dpaa2_eth_priv *priv,
buf_array[i] = addr;
/* tracing point */
- trace_dpaa2_eth_buf_seed(priv->net_dev,
- page, DPAA2_ETH_RX_BUF_RAW_SIZE,
+ trace_dpaa2_eth_buf_seed(priv->net_dev, page_address(page),
+ DPAA2_ETH_RX_BUF_RAW_SIZE,
addr, priv->rx_buf_size,
bpid);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dpaa2-eth: trace the allocated address instead of page struct
2022-08-10 23:29 [PATCH] dpaa2-eth: trace the allocated address instead of page struct Chen Lin
@ 2022-08-11 14:41 ` Ioana Ciornei
2022-08-11 15:16 ` [PATCH v2] " Chen Lin
0 siblings, 1 reply; 4+ messages in thread
From: Ioana Ciornei @ 2022-08-11 14:41 UTC (permalink / raw)
To: Chen Lin
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Yi Liu, Chen Lin
On Thu, Aug 11, 2022 at 07:29:48AM +0800, Chen Lin wrote:
> Follow the commit 27c874867c4(dpaa2-eth: Use a single page per Rx buffer),
> we should trace the allocated address instead of page struct.
>
> Signed-off-by: Chen Lin <chen.lin5@zte.com.cn>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Is this intended for the net tree? In that case, maybe it would be a
good idea to add a fixes tag to the commit that you are already
referencing.
Ioana
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] dpaa2-eth: trace the allocated address instead of page struct
2022-08-11 14:41 ` Ioana Ciornei
@ 2022-08-11 15:16 ` Chen Lin
2022-08-11 17:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 4+ messages in thread
From: Chen Lin @ 2022-08-11 15:16 UTC (permalink / raw)
To: ioana.ciornei
Cc: davem, edumazet, kuba, pabeni, netdev, linux-kernel, yi.liu,
Chen Lin, Chen Lin
We should trace the allocated address instead of page struct.
Fixes: 27c874867c4 ("dpaa2-eth: Use a single page per Rx buffer")
Signed-off-by: Chen Lin <chen.lin5@zte.com.cn>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index cd9ec8052..75d515726 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -1660,8 +1660,8 @@ static int dpaa2_eth_add_bufs(struct dpaa2_eth_priv *priv,
buf_array[i] = addr;
/* tracing point */
- trace_dpaa2_eth_buf_seed(priv->net_dev,
- page, DPAA2_ETH_RX_BUF_RAW_SIZE,
+ trace_dpaa2_eth_buf_seed(priv->net_dev, page_address(page),
+ DPAA2_ETH_RX_BUF_RAW_SIZE,
addr, priv->rx_buf_size,
bpid);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] dpaa2-eth: trace the allocated address instead of page struct
2022-08-11 15:16 ` [PATCH v2] " Chen Lin
@ 2022-08-11 17:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-08-11 17:40 UTC (permalink / raw)
To: Chen Lin
Cc: ioana.ciornei, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, yi.liu, chen.lin5
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 11 Aug 2022 23:16:51 +0800 you wrote:
> We should trace the allocated address instead of page struct.
>
> Fixes: 27c874867c4 ("dpaa2-eth: Use a single page per Rx buffer")
> Signed-off-by: Chen Lin <chen.lin5@zte.com.cn>
> Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [v2] dpaa2-eth: trace the allocated address instead of page struct
https://git.kernel.org/netdev/net/c/e34f49348f8b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-11 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-10 23:29 [PATCH] dpaa2-eth: trace the allocated address instead of page struct Chen Lin
2022-08-11 14:41 ` Ioana Ciornei
2022-08-11 15:16 ` [PATCH v2] " Chen Lin
2022-08-11 17:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox