From: Andrew Lunn <andrew@lunn.ch>
To: Nathan Whitehorn <nwhitehorn@pa.msu.edu>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, theo.lebrun@bootlin.com,
conor.dooley@microchip.com, charles.perry@microchip.com
Subject: Re: [PATCH net-next v4 1/2] net: macb: Poll for link state changes when using the internal PCS.
Date: Wed, 12 Aug 2026 18:22:29 +0200 [thread overview]
Message-ID: <16ca48e8-c9d5-4df5-b955-024349730ae2@lunn.ch> (raw)
In-Reply-To: <d130cf47-1d70-4345-b60a-795d463cb84a@pa.msu.edu>
> I am a little reticent to include fixes to this pre-existing situation in
> this patch unless it is unmergeable without doing so, especially given that
> I think a full solution would be a substantially larger change, but if it is
> needed, I would be happy to work on adding it.
> -Nathan
The way WoL works has been changed in phylink recently. Many MAC
drivers got it wrong, so we tried to make it easier by putting as much
business logic as possible into phylink.
So i would suggest you do a minimal fix for your issue, but also for
net-next try to rework WoL to make full use of phylinks code. So two
independent patchsets.
Andrew
next prev parent reply other threads:[~2026-08-12 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 20:07 [PATCH net-next v4 0/2] net: macb: 1000BASE-X on internal PCS Nathan Whitehorn
2026-08-07 20:07 ` [PATCH net-next v4 1/2] net: macb: Poll for link state changes when using the " Nathan Whitehorn
2026-08-12 1:54 ` Jakub Kicinski
2026-08-12 2:48 ` Nathan Whitehorn
2026-08-12 16:22 ` Andrew Lunn [this message]
2026-08-13 15:24 ` Nathan Whitehorn
2026-08-07 20:07 ` [PATCH net-next v4 2/2] net: macb: add support for 1000BASE-X autonegotiation to PCS Nathan Whitehorn
2026-08-12 1:54 ` Jakub Kicinski
2026-08-12 2:58 ` Nathan Whitehorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16ca48e8-c9d5-4df5-b955-024349730ae2@lunn.ch \
--to=andrew@lunn.ch \
--cc=charles.perry@microchip.com \
--cc=conor.dooley@microchip.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nwhitehorn@pa.msu.edu \
--cc=theo.lebrun@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox