From: Edward Cree <ecree@solarflare.com>
To: David Miller <davem@davemloft.net>, <jakub.kicinski@netronome.com>
Cc: <linux-net-drivers@solarflare.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 4/4] sfc: expose CTPIO stats on NICs that support them
Date: Wed, 20 Dec 2017 11:29:32 +0000 [thread overview]
Message-ID: <16e391db-b87f-7db5-4d6f-d8143bcddc49@solarflare.com> (raw)
In-Reply-To: <20171219.154256.506110072762756727.davem@davemloft.net>
On 19/12/17 20:42, David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Tue, 19 Dec 2017 12:20:36 -0800
>
>> On Tue, 19 Dec 2017 17:06:36 +0000, Edward Cree wrote:
>>> From: Bert Kenward <bkenward@solarflare.com>
>>>
>>> While the Linux driver doesn't use CTPIO ('cut-through programmed I/O'),
>>> other drivers on the same port might, so if we're responsible for
>>> reporting per-port stats we need to include the CTPIO stats.
>>>
>>> Signed-off-by: Edward Cree <ecree@solarflare.com>
>> FWIW this is missing a sign-off from Bert.
> Edward, please fix this and resubmit.
FWIW, our practice hitherto at Solarflare for patches written internally
has been to apply the SOB at the point of upstream submission; the
submitter is the person certifying (on behalf of the company) that the
patch is offered under a suitable license.
The motion of the patch within the company is not tracked with SOBs since —
as works-for-hire — the copyrights are all owned by the company rather
than the patch author.
If this is a problem we can start gathering SOBs from the authors for the
submission; but as I understand the DCoO that should not be necessary, and
it hasn't been considered a problem until recently.
Please advise on how we should handle this in future.
-Ed
next prev parent reply other threads:[~2017-12-20 11:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 17:03 [PATCH net-next 0/4] sfc: support extra stats on Medford2 Edward Cree
2017-12-19 17:05 ` [PATCH net-next 1/4] sfc: update MCDI protocol headers Edward Cree
2017-12-19 17:05 ` [PATCH net-next 2/4] sfc: support variable number of MAC stats Edward Cree
2017-12-19 17:06 ` [PATCH net-next 3/4] sfc: expose FEC stats on Medford2 Edward Cree
2017-12-19 17:06 ` [PATCH net-next 4/4] sfc: expose CTPIO stats on NICs that support them Edward Cree
2017-12-19 20:20 ` Jakub Kicinski
2017-12-19 20:42 ` David Miller
2017-12-20 11:29 ` Edward Cree [this message]
2017-12-20 17:30 ` David Miller
2017-12-20 11:14 ` Bert Kenward
2017-12-21 8:58 ` [PATCH v2 net-next 0/4] sfc: support extra stats on Medford2 Bert Kenward
2017-12-21 9:00 ` [PATCH v2 net-next 1/4] sfc: update MCDI protocol headers Bert Kenward
2017-12-21 9:00 ` [PATCH v2 net-next 2/4] sfc: support variable number of MAC stats Bert Kenward
2017-12-21 9:00 ` [PATCH v2 net-next 3/4] sfc: expose FEC stats on Medford2 Bert Kenward
2017-12-21 9:00 ` [PATCH v2 net-next 4/4] sfc: expose CTPIO stats on NICs that support them Bert Kenward
2017-12-21 20:15 ` [PATCH v2 net-next 0/4] sfc: support extra stats on Medford2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e391db-b87f-7db5-4d6f-d8143bcddc49@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox