* [PATCH net-next] selftests: drv-net: remove an unnecessary libmnl include
@ 2025-02-07 18:31 Jakub Kicinski
2025-02-07 18:32 ` Mina Almasry
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jakub Kicinski @ 2025-02-07 18:31 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
shuah, almasrymina, sdf, jdamato, linux-kselftest
ncdevmem doesn't need libmnl, remove the unnecessary include.
Since YNL doesn't depend on libmnl either, any more, it's actually
possible to build selftests without having libmnl installed.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: shuah@kernel.org
CC: almasrymina@google.com
CC: sdf@fomichev.me
CC: jdamato@fastly.com
CC: linux-kselftest@vger.kernel.org
---
tools/testing/selftests/drivers/net/hw/ncdevmem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/hw/ncdevmem.c b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
index 19a6969643f4..2bf14ac2b8c6 100644
--- a/tools/testing/selftests/drivers/net/hw/ncdevmem.c
+++ b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
@@ -50,7 +50,6 @@
#include <linux/memfd.h>
#include <linux/dma-buf.h>
#include <linux/udmabuf.h>
-#include <libmnl/libmnl.h>
#include <linux/types.h>
#include <linux/netlink.h>
#include <linux/genetlink.h>
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] selftests: drv-net: remove an unnecessary libmnl include
2025-02-07 18:31 [PATCH net-next] selftests: drv-net: remove an unnecessary libmnl include Jakub Kicinski
@ 2025-02-07 18:32 ` Mina Almasry
2025-02-07 18:41 ` Joe Damato
2025-02-11 3:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Mina Almasry @ 2025-02-07 18:32 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms, shuah, sdf,
jdamato, linux-kselftest
On Fri, Feb 7, 2025 at 10:31 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> ncdevmem doesn't need libmnl, remove the unnecessary include.
>
> Since YNL doesn't depend on libmnl either, any more, it's actually
> possible to build selftests without having libmnl installed.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Whoops, sorry about that.
Reviewed-by: Mina Almasry <almasrymina@google.com>
--
Thanks,
Mina
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] selftests: drv-net: remove an unnecessary libmnl include
2025-02-07 18:31 [PATCH net-next] selftests: drv-net: remove an unnecessary libmnl include Jakub Kicinski
2025-02-07 18:32 ` Mina Almasry
@ 2025-02-07 18:41 ` Joe Damato
2025-02-11 3:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Joe Damato @ 2025-02-07 18:41 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms, shuah,
almasrymina, sdf, linux-kselftest
On Fri, Feb 07, 2025 at 10:31:19AM -0800, Jakub Kicinski wrote:
> ncdevmem doesn't need libmnl, remove the unnecessary include.
>
> Since YNL doesn't depend on libmnl either, any more, it's actually
> possible to build selftests without having libmnl installed.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: shuah@kernel.org
> CC: almasrymina@google.com
> CC: sdf@fomichev.me
> CC: jdamato@fastly.com
> CC: linux-kselftest@vger.kernel.org
> ---
> tools/testing/selftests/drivers/net/hw/ncdevmem.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Joe Damato <jdamato@fastly.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] selftests: drv-net: remove an unnecessary libmnl include
2025-02-07 18:31 [PATCH net-next] selftests: drv-net: remove an unnecessary libmnl include Jakub Kicinski
2025-02-07 18:32 ` Mina Almasry
2025-02-07 18:41 ` Joe Damato
@ 2025-02-11 3:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-02-11 3:30 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms, shuah,
almasrymina, sdf, jdamato, linux-kselftest
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 7 Feb 2025 10:31:19 -0800 you wrote:
> ncdevmem doesn't need libmnl, remove the unnecessary include.
>
> Since YNL doesn't depend on libmnl either, any more, it's actually
> possible to build selftests without having libmnl installed.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net-next] selftests: drv-net: remove an unnecessary libmnl include
https://git.kernel.org/netdev/net-next/c/a980da54b6a4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-11 3:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-07 18:31 [PATCH net-next] selftests: drv-net: remove an unnecessary libmnl include Jakub Kicinski
2025-02-07 18:32 ` Mina Almasry
2025-02-07 18:41 ` Joe Damato
2025-02-11 3:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox