Re: [PATCH net-next v3] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor

[Xuan Zhuo <xuanzhuo@linux.alibaba.com>]

On Fri, 19 Sep 2025 18:35:51 +0200, Andrew Lunn <andrew@lunn.ch> wrote:
> > +static int eea_set_ringparam(struct net_device *netdev,
> > +			     struct ethtool_ringparam *ring,
> > +			     struct kernel_ethtool_ringparam *kernel_ring,
> > +			     struct netlink_ext_ack *extack)
> > +{
> > +	struct eea_net *enet = netdev_priv(netdev);
> > +	struct eea_net_tmp tmp = {};
> > +	bool need_update = false;
> > +	struct eea_net_cfg *cfg;
> > +	bool sh;
> > +
> > +	enet_mk_tmp_cfg(enet, &tmp);
> > +
> > +	cfg = &tmp.cfg;
> > +
> > +	if (ring->rx_mini_pending || ring->rx_jumbo_pending)
> > +		return -EINVAL;
>
> You have extack, so you can give a useful error message, in addition
> to EINVAL. set ringparam has soo many parameters it is hard to user
> space to know which values can be set. So seeing "rx_mini_pending not
> supported" is a big help.
>
> 	Andrew


YES. I see.

Thanks.
>