Re: [PATCH net-next v3] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor

[Xuan Zhuo <xuanzhuo@linux.alibaba.com>]

> > +			   struct eea_pci_device *ep_dev);
> > +static void __eea_pci_remove(struct pci_dev *pci_dev, bool flush_ha_work);
> > +
> > +const char *eea_pci_name(struct eea_device *edev)
>
> generally such a thin wrappers for kernel API are discouraged
> (this driver would be part of the kernel, if someone will change
> function that you call in a way that requires change of caller, they
> will also change your driver;
> it is also easier for reviewers and maintainers to see something
> common to them instead of eea_pci_dev_id())


I see. But I do this because that the sub struct of struct eea_device is
invisible from the out of eea_pci.c.

And the maintainers can change the code inside eea_pci.c directly, they
do not need to care about this api.

Thanks