* [PATCH net-next] r8152: Fix double consecutive clearing of PLA_MCU_SPDWN_EN bit
@ 2026-04-28 3:43 Birger Koblitz
2026-04-30 1:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Birger Koblitz @ 2026-04-28 3:43 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: linux-usb, netdev, linux-kernel, Chih Kai Hsu, Birger Koblitz
Due to a Copy & Paste Error, the PLA_MCU_SPDWN_EN bit was cleared
twice consecutively using ocp_word_clr_bits. Fix that.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
---
This fixes the issue raised in
https://lore.kernel.org/netdev/8b324f8c-f4f8-4e90-b5d6-9b87ec3daf2b@redhat.com/
that due to an editing error, PLA_MCU_SPDWN_EN is cleared twice
consecutively.
---
drivers/net/usb/r8152.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 7337bf1b7d6ad03572edbc492706c07a8f58760f..7dba5f3fd052d4db475e61f5c622d89ada1948c1 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -6839,9 +6839,6 @@ static void rtl8156_up(struct r8152 *tp)
ocp_word_w0w1(tp, MCU_TYPE_PLA, PLA_RXFIFO_FULL, RXFIFO_FULL_MASK,
0x08);
- ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3,
- PLA_MCU_SPDWN_EN);
-
ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN);
if (tp->version != RTL_VER_16)
---
base-commit: 35c2c39832e569449b9192fa1afbbc4c66227af7
change-id: 20260426-patch_double-1fc3cea4e9cc
Best regards,
--
Birger Koblitz <mail@birger-koblitz.de>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] r8152: Fix double consecutive clearing of PLA_MCU_SPDWN_EN bit
2026-04-28 3:43 [PATCH net-next] r8152: Fix double consecutive clearing of PLA_MCU_SPDWN_EN bit Birger Koblitz
@ 2026-04-30 1:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-04-30 1:00 UTC (permalink / raw)
To: Birger Koblitz
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, linux-usb, netdev,
linux-kernel, hsu.chih.kai
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 28 Apr 2026 05:43:38 +0200 you wrote:
> Due to a Copy & Paste Error, the PLA_MCU_SPDWN_EN bit was cleared
> twice consecutively using ocp_word_clr_bits. Fix that.
>
> Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
> ---
> This fixes the issue raised in
> https://lore.kernel.org/netdev/8b324f8c-f4f8-4e90-b5d6-9b87ec3daf2b@redhat.com/
> that due to an editing error, PLA_MCU_SPDWN_EN is cleared twice
> consecutively.
>
> [...]
Here is the summary with links:
- [net-next] r8152: Fix double consecutive clearing of PLA_MCU_SPDWN_EN bit
https://git.kernel.org/netdev/net-next/c/115553b80f77
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-30 1:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28 3:43 [PATCH net-next] r8152: Fix double consecutive clearing of PLA_MCU_SPDWN_EN bit Birger Koblitz
2026-04-30 1:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox