* [PATCH v2 net] sfc: fix error code in efx_devlink_info_running_versions()
@ 2026-04-29 6:48 Dan Carpenter
2026-04-29 15:27 ` Edward Cree
2026-04-30 11:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2026-04-29 6:48 UTC (permalink / raw)
To: Alejandro Lucero
Cc: Edward Cree, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Martin Habets, Jiri Pirko, netdev,
linux-net-drivers, linux-kernel, kernel-janitors
Return -EIO if efx_mcdi_rpc() doesn't return enough space.
Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
v2: Originally I returned -EINVAL but -EIO is the usual error code
when 'MC response was too short'
---
drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
index d842c60dfc10..e5c6f81af48b 100644
--- a/drivers/net/ethernet/sfc/efx_devlink.c
+++ b/drivers/net/ethernet/sfc/efx_devlink.c
@@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx,
if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) {
netif_err(efx, drv, efx->net_dev,
"mcdi MC_CMD_GET_VERSION failed\n");
- return rc;
+ return rc ?: -EIO;
}
/* Handle previous output */
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 net] sfc: fix error code in efx_devlink_info_running_versions()
2026-04-29 6:48 [PATCH v2 net] sfc: fix error code in efx_devlink_info_running_versions() Dan Carpenter
@ 2026-04-29 15:27 ` Edward Cree
2026-04-30 11:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Edward Cree @ 2026-04-29 15:27 UTC (permalink / raw)
To: Dan Carpenter, Alejandro Lucero
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Martin Habets, Jiri Pirko, netdev, linux-net-drivers,
linux-kernel, kernel-janitors
On 29/04/2026 07:48, Dan Carpenter wrote:
> Return -EIO if efx_mcdi_rpc() doesn't return enough space.
>
> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 net] sfc: fix error code in efx_devlink_info_running_versions()
2026-04-29 6:48 [PATCH v2 net] sfc: fix error code in efx_devlink_info_running_versions() Dan Carpenter
2026-04-29 15:27 ` Edward Cree
@ 2026-04-30 11:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-04-30 11:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: alejandro.lucero-palau, ecree.xilinx, andrew+netdev, davem,
edumazet, kuba, pabeni, habetsm.xilinx, jiri, netdev,
linux-net-drivers, linux-kernel, kernel-janitors
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 29 Apr 2026 09:48:17 +0300 you wrote:
> Return -EIO if efx_mcdi_rpc() doesn't return enough space.
>
> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> v2: Originally I returned -EINVAL but -EIO is the usual error code
> when 'MC response was too short'
>
> [...]
Here is the summary with links:
- [v2,net] sfc: fix error code in efx_devlink_info_running_versions()
https://git.kernel.org/netdev/net/c/051ffb001b8a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-30 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-29 6:48 [PATCH v2 net] sfc: fix error code in efx_devlink_info_running_versions() Dan Carpenter
2026-04-29 15:27 ` Edward Cree
2026-04-30 11:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox