public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family
@ 2026-05-04 15:32 Marek Behún
  2026-05-04 15:32 ` [PATCH net-next 1/5] net: dsa: mv88e6xxx: fix number of g1 interrupts for 6320 family Marek Behún
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Marek Behún @ 2026-05-04 15:32 UTC (permalink / raw)
  To: Andrew Lunn, Vladimir Oltean, Russell King (Oracle),
	Vivien Didelot, Tobias Waldekranz, netdev, Fidan Aliyeva
  Cc: Lev Olshvang, Marek Behún

Five fixes for mv88e6xxx for 6320/6321 family, for net-next, without
Fixes tags, as per Andrew's request last year, see
https://lore.kernel.org/netdev/20250313134146.27087-1-kabel@kernel.org/

Marek Behún (5):
  net: dsa: mv88e6xxx: fix number of g1 interrupts for 6320 family
  net: dsa: mv88e6xxx: allow SPEED_200 for 6320 family on supported
    ports
  net: dsa: mv88e6xxx: define .pot_clear() for 6321
  net: dsa: mv88e6xxx: enable .rmu_disable() for 6320 family
  net: dsa: mv88e6xxx: enable devlink ATU hash param for 6320 family

 drivers/net/dsa/mv88e6xxx/chip.c | 15 +++++++++++----
 drivers/net/dsa/mv88e6xxx/port.c | 15 +++++++++++++++
 drivers/net/dsa/mv88e6xxx/port.h |  2 ++
 3 files changed, 28 insertions(+), 4 deletions(-)

-- 
2.53.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH net-next 1/5] net: dsa: mv88e6xxx: fix number of g1 interrupts for 6320 family
  2026-05-04 15:32 [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family Marek Behún
@ 2026-05-04 15:32 ` Marek Behún
  2026-05-04 15:32 ` [PATCH net-next 2/5] net: dsa: mv88e6xxx: allow SPEED_200 for 6320 family on supported ports Marek Behún
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Marek Behún @ 2026-05-04 15:32 UTC (permalink / raw)
  To: Andrew Lunn, Vladimir Oltean, Russell King (Oracle),
	Vivien Didelot, Tobias Waldekranz, netdev, Fidan Aliyeva
  Cc: Lev Olshvang, Marek Behún

The 6320 family has 9 global1 interrupt, not 8. Fix it.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index c618abc75ebb..338cba0c8364 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -6280,7 +6280,7 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = {
 		.global1_addr = 0x1b,
 		.global2_addr = 0x1c,
 		.age_time_coeff = 15000,
-		.g1_irqs = 8,
+		.g1_irqs = 9,
 		.g2_irqs = 10,
 		.stats_type = STATS_TYPE_BANK0 | STATS_TYPE_BANK1,
 		.atu_move_port_mask = 0xf,
@@ -6308,7 +6308,7 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = {
 		.global1_addr = 0x1b,
 		.global2_addr = 0x1c,
 		.age_time_coeff = 15000,
-		.g1_irqs = 8,
+		.g1_irqs = 9,
 		.g2_irqs = 10,
 		.stats_type = STATS_TYPE_BANK0 | STATS_TYPE_BANK1,
 		.atu_move_port_mask = 0xf,
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH net-next 2/5] net: dsa: mv88e6xxx: allow SPEED_200 for 6320 family on supported ports
  2026-05-04 15:32 [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family Marek Behún
  2026-05-04 15:32 ` [PATCH net-next 1/5] net: dsa: mv88e6xxx: fix number of g1 interrupts for 6320 family Marek Behún
@ 2026-05-04 15:32 ` Marek Behún
  2026-05-04 15:32 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: define .pot_clear() for 6321 Marek Behún
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Marek Behún @ 2026-05-04 15:32 UTC (permalink / raw)
  To: Andrew Lunn, Vladimir Oltean, Russell King (Oracle),
	Vivien Didelot, Tobias Waldekranz, netdev, Fidan Aliyeva
  Cc: Lev Olshvang, Marek Behún

The 6320 family supports the ALT_SPEED bit on ports 2, 5 and 6. Allow
this speed by implementing 6320 family specific .port_set_speed_duplex()
method.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/net/dsa/mv88e6xxx/chip.c |  4 ++--
 drivers/net/dsa/mv88e6xxx/port.c | 15 +++++++++++++++
 drivers/net/dsa/mv88e6xxx/port.h |  2 ++
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 338cba0c8364..78799666e6b7 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -5168,7 +5168,7 @@ static const struct mv88e6xxx_ops mv88e6320_ops = {
 	.port_set_link = mv88e6xxx_port_set_link,
 	.port_sync_link = mv88e6xxx_port_sync_link,
 	.port_set_rgmii_delay = mv88e6320_port_set_rgmii_delay,
-	.port_set_speed_duplex = mv88e6185_port_set_speed_duplex,
+	.port_set_speed_duplex = mv88e6320_port_set_speed_duplex,
 	.port_tag_remap = mv88e6095_port_tag_remap,
 	.port_set_policy = mv88e6352_port_set_policy,
 	.port_set_frame_mode = mv88e6351_port_set_frame_mode,
@@ -5221,7 +5221,7 @@ static const struct mv88e6xxx_ops mv88e6321_ops = {
 	.port_set_link = mv88e6xxx_port_set_link,
 	.port_sync_link = mv88e6xxx_port_sync_link,
 	.port_set_rgmii_delay = mv88e6320_port_set_rgmii_delay,
-	.port_set_speed_duplex = mv88e6185_port_set_speed_duplex,
+	.port_set_speed_duplex = mv88e6320_port_set_speed_duplex,
 	.port_tag_remap = mv88e6095_port_tag_remap,
 	.port_set_policy = mv88e6352_port_set_policy,
 	.port_set_frame_mode = mv88e6351_port_set_frame_mode,
diff --git a/drivers/net/dsa/mv88e6xxx/port.c b/drivers/net/dsa/mv88e6xxx/port.c
index 74cfc0bb7b5b..ea1fab71968a 100644
--- a/drivers/net/dsa/mv88e6xxx/port.c
+++ b/drivers/net/dsa/mv88e6xxx/port.c
@@ -327,6 +327,21 @@ int mv88e6250_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
 					       duplex);
 }
 
+int mv88e6320_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
+				    int speed, int duplex)
+{
+	bool has_200 = (port == 2 || port == 5 || port == 6);
+
+	if (speed > 1000)
+		return -EOPNOTSUPP;
+
+	if (speed == 200 && !has_200)
+		return -EOPNOTSUPP;
+
+	return mv88e6xxx_port_set_speed_duplex(chip, port, speed, has_200,
+					       false, duplex);
+}
+
 /* Support 10, 100, 200, 1000, 2500 Mbps (e.g. 88E6341) */
 int mv88e6341_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
 				    int speed, int duplex)
diff --git a/drivers/net/dsa/mv88e6xxx/port.h b/drivers/net/dsa/mv88e6xxx/port.h
index 44b100dd618b..5b6cde9f7406 100644
--- a/drivers/net/dsa/mv88e6xxx/port.h
+++ b/drivers/net/dsa/mv88e6xxx/port.h
@@ -493,6 +493,8 @@ int mv88e6185_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
 				    int speed, int duplex);
 int mv88e6250_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
 				    int speed, int duplex);
+int mv88e6320_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
+				    int speed, int duplex);
 int mv88e6341_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
 				    int speed, int duplex);
 int mv88e6352_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH net-next 3/5] net: dsa: mv88e6xxx: define .pot_clear() for 6321
  2026-05-04 15:32 [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family Marek Behún
  2026-05-04 15:32 ` [PATCH net-next 1/5] net: dsa: mv88e6xxx: fix number of g1 interrupts for 6320 family Marek Behún
  2026-05-04 15:32 ` [PATCH net-next 2/5] net: dsa: mv88e6xxx: allow SPEED_200 for 6320 family on supported ports Marek Behún
@ 2026-05-04 15:32 ` Marek Behún
  2026-05-04 15:32 ` [PATCH net-next 4/5] net: dsa: mv88e6xxx: enable .rmu_disable() for 6320 family Marek Behún
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Marek Behún @ 2026-05-04 15:32 UTC (permalink / raw)
  To: Andrew Lunn, Vladimir Oltean, Russell King (Oracle),
	Vivien Didelot, Tobias Waldekranz, netdev, Fidan Aliyeva
  Cc: Lev Olshvang, Marek Behún

Commit 9e907d739cc3 ("net: dsa: mv88e6xxx: add POT operation") did not
add the .pot_clear() method to the 6321 switch operations structure.
Add them now.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 78799666e6b7..b55a9d4a1ee1 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -5244,6 +5244,7 @@ static const struct mv88e6xxx_ops mv88e6321_ops = {
 	.set_egress_port = mv88e6095_g1_set_egress_port,
 	.watchdog_ops = &mv88e6390_watchdog_ops,
 	.mgmt_rsvd2cpu = mv88e6352_g2_mgmt_rsvd2cpu,
+	.pot_clear = mv88e6xxx_g2_pot_clear,
 	.hardware_reset_pre = mv88e6xxx_g2_eeprom_wait,
 	.hardware_reset_post = mv88e6xxx_g2_eeprom_wait,
 	.reset = mv88e6352_g1_reset,
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH net-next 4/5] net: dsa: mv88e6xxx: enable .rmu_disable() for 6320 family
  2026-05-04 15:32 [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family Marek Behún
                   ` (2 preceding siblings ...)
  2026-05-04 15:32 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: define .pot_clear() for 6321 Marek Behún
@ 2026-05-04 15:32 ` Marek Behún
  2026-05-04 15:32 ` [PATCH net-next 5/5] net: dsa: mv88e6xxx: enable devlink ATU hash param " Marek Behún
  2026-05-06  1:50 ` [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family patchwork-bot+netdevbpf
  5 siblings, 0 replies; 7+ messages in thread
From: Marek Behún @ 2026-05-04 15:32 UTC (permalink / raw)
  To: Andrew Lunn, Vladimir Oltean, Russell King (Oracle),
	Vivien Didelot, Tobias Waldekranz, netdev, Fidan Aliyeva
  Cc: Lev Olshvang, Marek Behún

Commit 9e5baf9b3636 ("net: dsa: mv88e6xxx: add RMU disable op") did not
add the .rmu_disable() method for the 6320 family. Add it now.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index b55a9d4a1ee1..09da154f80d7 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -5195,6 +5195,7 @@ static const struct mv88e6xxx_ops mv88e6320_ops = {
 	.hardware_reset_pre = mv88e6xxx_g2_eeprom_wait,
 	.hardware_reset_post = mv88e6xxx_g2_eeprom_wait,
 	.reset = mv88e6352_g1_reset,
+	.rmu_disable = mv88e6352_g1_rmu_disable,
 	.vtu_getnext = mv88e6352_g1_vtu_getnext,
 	.vtu_loadpurge = mv88e6352_g1_vtu_loadpurge,
 	.stu_getnext = mv88e6352_g1_stu_getnext,
@@ -5248,6 +5249,7 @@ static const struct mv88e6xxx_ops mv88e6321_ops = {
 	.hardware_reset_pre = mv88e6xxx_g2_eeprom_wait,
 	.hardware_reset_post = mv88e6xxx_g2_eeprom_wait,
 	.reset = mv88e6352_g1_reset,
+	.rmu_disable = mv88e6352_g1_rmu_disable,
 	.vtu_getnext = mv88e6352_g1_vtu_getnext,
 	.vtu_loadpurge = mv88e6352_g1_vtu_loadpurge,
 	.stu_getnext = mv88e6352_g1_stu_getnext,
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH net-next 5/5] net: dsa: mv88e6xxx: enable devlink ATU hash param for 6320 family
  2026-05-04 15:32 [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family Marek Behún
                   ` (3 preceding siblings ...)
  2026-05-04 15:32 ` [PATCH net-next 4/5] net: dsa: mv88e6xxx: enable .rmu_disable() for 6320 family Marek Behún
@ 2026-05-04 15:32 ` Marek Behún
  2026-05-06  1:50 ` [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family patchwork-bot+netdevbpf
  5 siblings, 0 replies; 7+ messages in thread
From: Marek Behún @ 2026-05-04 15:32 UTC (permalink / raw)
  To: Andrew Lunn, Vladimir Oltean, Russell King (Oracle),
	Vivien Didelot, Tobias Waldekranz, netdev, Fidan Aliyeva
  Cc: Lev Olshvang, Marek Behún

Commit 23e8b470c7788 ("net: dsa: mv88e6xxx: Add devlink param for ATU
hash algorithm.") introduced ATU hash algorithm access via devlink, but
did not enable it for the 6320 family. Do it now.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 09da154f80d7..4234755100ea 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -5196,6 +5196,8 @@ static const struct mv88e6xxx_ops mv88e6320_ops = {
 	.hardware_reset_post = mv88e6xxx_g2_eeprom_wait,
 	.reset = mv88e6352_g1_reset,
 	.rmu_disable = mv88e6352_g1_rmu_disable,
+	.atu_get_hash = mv88e6165_g1_atu_get_hash,
+	.atu_set_hash = mv88e6165_g1_atu_set_hash,
 	.vtu_getnext = mv88e6352_g1_vtu_getnext,
 	.vtu_loadpurge = mv88e6352_g1_vtu_loadpurge,
 	.stu_getnext = mv88e6352_g1_stu_getnext,
@@ -5250,6 +5252,8 @@ static const struct mv88e6xxx_ops mv88e6321_ops = {
 	.hardware_reset_post = mv88e6xxx_g2_eeprom_wait,
 	.reset = mv88e6352_g1_reset,
 	.rmu_disable = mv88e6352_g1_rmu_disable,
+	.atu_get_hash = mv88e6165_g1_atu_get_hash,
+	.atu_set_hash = mv88e6165_g1_atu_set_hash,
 	.vtu_getnext = mv88e6352_g1_vtu_getnext,
 	.vtu_loadpurge = mv88e6352_g1_vtu_loadpurge,
 	.stu_getnext = mv88e6352_g1_stu_getnext,
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family
  2026-05-04 15:32 [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family Marek Behún
                   ` (4 preceding siblings ...)
  2026-05-04 15:32 ` [PATCH net-next 5/5] net: dsa: mv88e6xxx: enable devlink ATU hash param " Marek Behún
@ 2026-05-06  1:50 ` patchwork-bot+netdevbpf
  5 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-05-06  1:50 UTC (permalink / raw)
  To: =?utf-8?q?Marek_Beh=C3=BAn_=3Ckabel=40kernel=2Eorg=3E?=
  Cc: andrew, olteanv, rmk+kernel, vivien.didelot, tobias, netdev,
	fidan.aliyeva.ext, lev_o

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  4 May 2026 17:32:22 +0200 you wrote:
> Five fixes for mv88e6xxx for 6320/6321 family, for net-next, without
> Fixes tags, as per Andrew's request last year, see
> https://lore.kernel.org/netdev/20250313134146.27087-1-kabel@kernel.org/
> 
> Marek Behún (5):
>   net: dsa: mv88e6xxx: fix number of g1 interrupts for 6320 family
>   net: dsa: mv88e6xxx: allow SPEED_200 for 6320 family on supported
>     ports
>   net: dsa: mv88e6xxx: define .pot_clear() for 6321
>   net: dsa: mv88e6xxx: enable .rmu_disable() for 6320 family
>   net: dsa: mv88e6xxx: enable devlink ATU hash param for 6320 family
> 
> [...]

Here is the summary with links:
  - [net-next,1/5] net: dsa: mv88e6xxx: fix number of g1 interrupts for 6320 family
    https://git.kernel.org/netdev/net-next/c/d201c2612e5a
  - [net-next,2/5] net: dsa: mv88e6xxx: allow SPEED_200 for 6320 family on supported ports
    https://git.kernel.org/netdev/net-next/c/965871277f60
  - [net-next,3/5] net: dsa: mv88e6xxx: define .pot_clear() for 6321
    https://git.kernel.org/netdev/net-next/c/17826d9708a5
  - [net-next,4/5] net: dsa: mv88e6xxx: enable .rmu_disable() for 6320 family
    https://git.kernel.org/netdev/net-next/c/e0fdb4157a85
  - [net-next,5/5] net: dsa: mv88e6xxx: enable devlink ATU hash param for 6320 family
    https://git.kernel.org/netdev/net-next/c/1010deac776a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-05-06  1:51 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-04 15:32 [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family Marek Behún
2026-05-04 15:32 ` [PATCH net-next 1/5] net: dsa: mv88e6xxx: fix number of g1 interrupts for 6320 family Marek Behún
2026-05-04 15:32 ` [PATCH net-next 2/5] net: dsa: mv88e6xxx: allow SPEED_200 for 6320 family on supported ports Marek Behún
2026-05-04 15:32 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: define .pot_clear() for 6321 Marek Behún
2026-05-04 15:32 ` [PATCH net-next 4/5] net: dsa: mv88e6xxx: enable .rmu_disable() for 6320 family Marek Behún
2026-05-04 15:32 ` [PATCH net-next 5/5] net: dsa: mv88e6xxx: enable devlink ATU hash param " Marek Behún
2026-05-06  1:50 ` [PATCH net-next 0/5] Fixes for mv88e6xxx for 6320/6321 family patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox