[PATCH net-next] bnxt_en: Drop pci_save_state() after pci_restore_state()

[PATCH net-next] bnxt_en: Drop pci_save_state() after pci_restore_state()

[Lukas Wunner]

Commit 383d89699c50 ("treewide: Drop pci_save_state() after
pci_restore_state()") sought to purge all superfluous invocations of
pci_save_state() from the tree.

Unfortunately the commit missed one invocation in the Broadcom
NetXtreme-C/E driver.  Drop it.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 8c55874..10196f9 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -17386,7 +17386,6 @@ static pci_ers_result_t bnxt_io_slot_reset(struct pci_dev *pdev)
 				pci_write_config_dword(bp->pdev, off, 0);
 		}
 		pci_restore_state(pdev);
-		pci_save_state(pdev);
 
 		bnxt_inv_fw_health_reg(bp);
 		bnxt_try_map_fw_health_reg(bp);
-- 
2.51.0

Re: [PATCH net-next] bnxt_en: Drop pci_save_state() after pci_restore_state()

[Pavan Chebbi]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Thu, May 7, 2026 at 6:34 PM Lukas Wunner <lukas@wunner.de> wrote:
>
> Commit 383d89699c50 ("treewide: Drop pci_save_state() after
> pci_restore_state()") sought to purge all superfluous invocations of
> pci_save_state() from the tree.
>
> Unfortunately the commit missed one invocation in the Broadcom
> NetXtreme-C/E driver.  Drop it.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5469 bytes --]

Re: [PATCH net-next] bnxt_en: Drop pci_save_state() after pci_restore_state()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 7 May 2026 15:04:59 +0200 you wrote:
> Commit 383d89699c50 ("treewide: Drop pci_save_state() after
> pci_restore_state()") sought to purge all superfluous invocations of
> pci_save_state() from the tree.
> 
> Unfortunately the commit missed one invocation in the Broadcom
> NetXtreme-C/E driver.  Drop it.
> 
> [...]

Here is the summary with links:
  - [net-next] bnxt_en: Drop pci_save_state() after pci_restore_state()
    https://git.kernel.org/netdev/net-next/c/04ae0d54c1b1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html