From: patchwork-bot+netdevbpf@kernel.org
To: Tao Cui <cuitao@kylinos.cn>
Cc: andrew@lunn.ch, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
vadim.fedorenko@linux.dev, leitao@debian.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net v2] net: ethtool: fix missing closing paren in rings_reply_size()
Date: Tue, 12 May 2026 01:49:00 +0000 [thread overview]
Message-ID: <177855054004.2567715.4961349489571823460.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260508125412.189804-1-cuitao@kylinos.cn>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 8 May 2026 20:54:12 +0800 you wrote:
> sizeof(u32) on the _RINGS_CQE_SIZE line is missing its closing
> parenthesis, causing nla_total_size() to absorb the subsequent
> _TX_PUSH and _RX_PUSH entries. The resulting size estimate
> happens to be numerically identical due to NLA alignment, but
> the nesting is wrong and misleading.
>
> Fixes: 4dc84c06a343 ("net: ethtool: extend ringparam set/get APIs for tx_push")
> Signed-off-by: Tao Cui <cuitao@kylinos.cn>
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> Reviewed-by: Breno Leitao <leitao@debian.org>
>
> [...]
Here is the summary with links:
- [net,v2] net: ethtool: fix missing closing paren in rings_reply_size()
https://git.kernel.org/netdev/net-next/c/73d587ae684d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2026-05-12 1:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 12:54 [PATCH net v2] net: ethtool: fix missing closing paren in rings_reply_size() Tao Cui
2026-05-12 1:49 ` patchwork-bot+netdevbpf [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-08 9:33 [PATCH] " Breno Leitao
2026-05-08 10:04 ` [PATCH net v2] " Tao Cui
2026-05-08 12:07 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177855054004.2567715.4961349489571823460.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew@lunn.ch \
--cc=cuitao@kylinos.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox