* [PATCHv2 net] net: ag71xx: check error for platform_get_irq
@ 2026-05-16 21:26 Rosen Penev
2026-05-19 9:46 ` Oleksij Rempel
2026-05-21 0:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2026-05-16 21:26 UTC (permalink / raw)
To: netdev
Cc: Chris Snook, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Oleksij Rempel, open list
Complete error handling for a failed platform_get_irq() call
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: adjust description
drivers/net/ethernet/atheros/ag71xx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index a5ab99474179..4e4794c4dfdc 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -1856,6 +1856,9 @@ static int ag71xx_probe(struct platform_device *pdev)
ag71xx_int_disable(ag, AG71XX_INT_POLL);
ndev->irq = platform_get_irq(pdev, 0);
+ if (ndev->irq < 0)
+ return ndev->irq;
+
err = devm_request_irq(&pdev->dev, ndev->irq, ag71xx_interrupt,
0x0, dev_name(&pdev->dev), ndev);
if (err) {
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv2 net] net: ag71xx: check error for platform_get_irq
2026-05-16 21:26 [PATCHv2 net] net: ag71xx: check error for platform_get_irq Rosen Penev
@ 2026-05-19 9:46 ` Oleksij Rempel
2026-05-21 0:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Oleksij Rempel @ 2026-05-19 9:46 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Chris Snook, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, open list
On Sat, May 16, 2026 at 02:26:16PM -0700, Rosen Penev wrote:
> Complete error handling for a failed platform_get_irq() call
>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
LGTM,
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2 net] net: ag71xx: check error for platform_get_irq
2026-05-16 21:26 [PATCHv2 net] net: ag71xx: check error for platform_get_irq Rosen Penev
2026-05-19 9:46 ` Oleksij Rempel
@ 2026-05-21 0:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-05-21 0:00 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, chris.snook, andrew+netdev, davem, edumazet, kuba, pabeni,
o.rempel, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 16 May 2026 14:26:16 -0700 you wrote:
> Complete error handling for a failed platform_get_irq() call
>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> v2: adjust description
> drivers/net/ethernet/atheros/ag71xx.c | 3 +++
> 1 file changed, 3 insertions(+)
Here is the summary with links:
- [PATCHv2,net] net: ag71xx: check error for platform_get_irq
https://git.kernel.org/netdev/net/c/e7c70bf97e90
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-21 0:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-16 21:26 [PATCHv2 net] net: ag71xx: check error for platform_get_irq Rosen Penev
2026-05-19 9:46 ` Oleksij Rempel
2026-05-21 0:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox