[PATCH net] octeontx2-af: npc: Fix allmulticast skip logic for LBK and SDP VFs

[PATCH net] octeontx2-af: npc: Fix allmulticast skip logic for LBK and SDP VFs

[Ratheesh Kannoth]

When installing the allmulticast NPC rule, rvu_npc_install_allmulti_entry()
should skip LBK and SDP VFs (only CGX PF/VF may add the entry).  The
code combined is_lbk_vf() and is_sdp_vf() with logical AND, which is
never true for a single pcifunc, so the intended early return never ran.

Use logical OR instead.

Cc: Geetha sowjanya <gakula@marvell.com>
Fixes: ae703539f49d2 ("octeontx2-af: Cleanup loopback device checks")
Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
index 3c814d157ab9..607d0cf1a778 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
@@ -990,7 +990,7 @@ void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
 	u16 vf_func;
 
 	/* Only CGX PF/VF can add allmulticast entry */
-	if (is_lbk_vf(rvu, pcifunc) && is_sdp_vf(rvu, pcifunc))
+	if (is_lbk_vf(rvu, pcifunc) || is_sdp_vf(rvu, pcifunc))
 		return;
 
 	blkaddr = rvu_get_blkaddr(rvu, BLKTYPE_NPC, 0);
-- 
2.43.0

Re: [PATCH net] octeontx2-af: npc: Fix allmulticast skip logic for LBK and SDP VFs

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 20 May 2026 10:00:36 +0530 you wrote:
> When installing the allmulticast NPC rule, rvu_npc_install_allmulti_entry()
> should skip LBK and SDP VFs (only CGX PF/VF may add the entry).  The
> code combined is_lbk_vf() and is_sdp_vf() with logical AND, which is
> never true for a single pcifunc, so the intended early return never ran.
> 
> Use logical OR instead.
> 
> [...]

Here is the summary with links:
  - [net] octeontx2-af: npc: Fix allmulticast skip logic for LBK and SDP VFs
    https://git.kernel.org/netdev/net/c/9eddc819f00b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html