From: patchwork-bot+netdevbpf@kernel.org
To: Weiming Shi <bestswngs@gmail.com>
Cc: netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com,
jasowang@redhat.com, pabeni@redhat.com, kuba@kernel.org,
edumazet@google.com, dongli.zhang@oracle.com, xmei5@asu.edu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] tun: free page on short-frame rejection in tun_xdp_one()
Date: Fri, 22 May 2026 15:00:07 +0000 [thread overview]
Message-ID: <177946200752.1252088.3077671165200798159.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260520160020.375349-2-bestswngs@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 20 May 2026 09:00:21 -0700 you wrote:
> tun_xdp_one() returns -EINVAL on a frame shorter than ETH_HLEN without
> freeing the page that vhost_net_build_xdp() allocated for it.
> tun_sendmsg() discards that -EINVAL and still returns total_len, so
> vhost_tx_batch() takes the success path and never frees the page; each
> short frame in a batch leaks one page-frag chunk.
>
> A local process that can open /dev/net/tun and /dev/vhost-net can hit
> this path: it attaches a tun/tap device as the vhost-net backend and
> feeds TX descriptors whose length minus the virtio-net header is below
> ETH_HLEN. Each kick leaks the page-frag chunks for that batch, and a
> tight submission loop exhausts host memory and triggers an OOM panic.
> Free the page before returning -EINVAL, matching the XDP-program error
> path in the same function.
>
> [...]
Here is the summary with links:
- [net] tun: free page on short-frame rejection in tun_xdp_one()
https://git.kernel.org/netdev/net/c/f4feb1e20058
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-05-22 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 16:00 [PATCH net] tun: free page on short-frame rejection in tun_xdp_one() Weiming Shi
2026-05-21 0:05 ` Willem de Bruijn
2026-05-21 0:37 ` Dongli Zhang
2026-05-21 0:58 ` Willem de Bruijn
2026-05-21 16:44 ` Weiming Shi
2026-05-21 21:01 ` Dongli Zhang
2026-05-22 13:39 ` Willem de Bruijn
2026-05-22 15:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177946200752.1252088.3077671165200798159.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bestswngs@gmail.com \
--cc=dongli.zhang@oracle.com \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox