From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Florian Fainelli <f.fainelli@gmail.com>,
thomas.petazzoni@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next] Documentation: networking: Add a test plan for ethtool pause validation
Date: Fri, 29 May 2026 09:39:51 +0800 [thread overview]
Message-ID: <1780018791.8076131-1-xuanzhuo@linux.alibaba.com> (raw)
In-Reply-To: <81777bc8-b046-4c76-9f53-e33563b6ad62@lunn.ch>
On Wed, 27 May 2026 14:08:30 +0200, Andrew Lunn <andrew@lunn.ch> wrote:
> > As for the kAPI testing, I agree that the end goal is to get driver
> > authors to get their flow control implementation right running this
> > suite.
> >
> > But I don't really see how we can validate kAPI itself, as we're down at
> > the ethnl level.
>
> All we can do is invoke the kAPI in different ways, and test we get
> the expected results. When it fails, it is down to the developer to
> figure out why, which layer. But they have a description of what the
> test is doing, and why? In most reviews, all i need to explain is the
> expected behaviour, and the second version is correct. So a test with
> explanation text should sort cut that process. I don't think we need
> any more.
>
> To some extent, we have an iterative process here. We have never done
> testing of this, we don't know exactly what we need. If we get
> feedback that a test is failing, but they cannot figure out why, we
> might need to help out, and then extend either the text, or add finer
> grain testing to narrow down the problem space. If we get a submission
> which passes all the tests but review turns up problems, we might want
> to ask the developers to extend the tests to catch the failure.
>
So I've been thinking lately: should we let AI generate and maintain these tests,
including kselftest? This would give us a much richer and more comprehensive
set of tests. Plus, each test could come with a complete explanation of its
purpose and methodology. In short, much of the work we used to do manually
can be offloaded to AI. This way, we can build a massive test suite and
achieve much broader coverage.
I'm actually trying this out right now.
Thanks.
> Andrew
>
next prev parent reply other threads:[~2026-05-29 1:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 17:51 [PATCH net-next] Documentation: networking: Add a test plan for ethtool pause validation Maxime Chevallier (Netdev Foundation)
2026-05-27 0:24 ` Jakub Kicinski
2026-05-27 2:47 ` Andrew Lunn
2026-05-27 7:07 ` Maxime Chevallier
2026-05-27 12:08 ` Andrew Lunn
2026-05-29 1:39 ` Xuan Zhuo [this message]
2026-05-29 2:52 ` Andrew Lunn
2026-05-27 23:25 ` Jakub Kicinski
2026-05-29 7:24 ` Maxime Chevallier
2026-05-29 12:30 ` Andrew Lunn
2026-05-29 7:42 ` Maxime Chevallier
2026-05-29 7:50 ` Oleksij Rempel
2026-06-25 15:29 ` Maxime Chevallier
2026-06-25 16:12 ` Andrew Lunn
2026-06-26 8:33 ` Maxime Chevallier
2026-06-26 12:39 ` Andrew Lunn
2026-06-26 12:51 ` Maxime Chevallier
2026-06-27 0:33 ` Jakub Kicinski
2026-06-27 5:34 ` Maxime Chevallier
2026-06-27 21:30 ` Jakub Kicinski
2026-06-27 23:46 ` Andrew Lunn
2026-06-29 15:24 ` Maxime Chevallier
2026-06-29 22:40 ` Jakub Kicinski
2026-05-27 6:41 ` Maxime Chevallier
2026-05-27 3:13 ` Andrew Lunn
2026-05-28 1:15 ` Andrew Lunn
2026-05-29 8:07 ` Maxime Chevallier
2026-05-29 12:59 ` Andrew Lunn
2026-05-29 13:20 ` Maxime Chevallier
2026-06-25 10:46 ` Maxime Chevallier
2026-06-25 15:46 ` Andrew Lunn
2026-06-25 16:03 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1780018791.8076131-1-xuanzhuo@linux.alibaba.com \
--to=xuanzhuo@linux.alibaba.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox