* [PATCH net v3] net: txgbe: fix phylink leak on AML init failure
@ 2026-05-28 1:32 Chenguang Zhao
2026-06-02 2:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Chenguang Zhao @ 2026-05-28 1:32 UTC (permalink / raw)
To: Jiawen Wu, Mengyuan Lou, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Chevallier
Cc: Chenguang Zhao, Simon Horman, netdev
Destroy the phylink instance when fixed-link setup fails.
Fixes: 6f8b4c01a8cd ("net: txgbe: Implement PHYLINK for AML 25G/10G devices")
Signed-off-by: Chenguang Zhao <zhaochenguang@kylinos.cn>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
v3:
- Adjusted the subject prefix as suggested by Maxime.
v2:
https://lore.kernel.org/all/20260526090559.2095680-1-zhaochenguang@kylinos.cn/
v1:
https://lore.kernel.org/all/20260522070749.1634542-1-zhaochenguang@kylinos.cn/
---
drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
index f0514251d4f3..8e301e7d1148 100644
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
@@ -521,6 +521,7 @@ int txgbe_phylink_init_aml(struct txgbe *txgbe)
err = phylink_set_fixed_link(phylink, &state);
if (err) {
wx_err(wx, "Failed to set fixed link\n");
+ phylink_destroy(phylink);
return err;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v3] net: txgbe: fix phylink leak on AML init failure
2026-05-28 1:32 [PATCH net v3] net: txgbe: fix phylink leak on AML init failure Chenguang Zhao
@ 2026-06-02 2:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-02 2:50 UTC (permalink / raw)
To: Chenguang Zhao
Cc: jiawenwu, mengyuanlou, andrew+netdev, davem, edumazet, kuba,
pabeni, maxime.chevallier, horms, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 28 May 2026 09:32:58 +0800 you wrote:
> Destroy the phylink instance when fixed-link setup fails.
>
> Fixes: 6f8b4c01a8cd ("net: txgbe: Implement PHYLINK for AML 25G/10G devices")
> Signed-off-by: Chenguang Zhao <zhaochenguang@kylinos.cn>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
>
> [...]
Here is the summary with links:
- [net,v3] net: txgbe: fix phylink leak on AML init failure
https://git.kernel.org/netdev/net-next/c/9c89f975e669
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-02 2:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-28 1:32 [PATCH net v3] net: txgbe: fix phylink leak on AML init failure Chenguang Zhao
2026-06-02 2:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox