[PATCH RESEND net] net: mv643xx: fix OF node refcount

[PATCH RESEND net] net: mv643xx: fix OF node refcount

[Bartosz Golaszewski]

Platform devices created with platform_device_alloc() call
platform_device_release() when the last reference to the device's
kobject is dropped. This function calls of_node_put() unconditionally.
This works fine for devices created with platform_device_register_full()
but users of the split approach (platform_device_alloc() +
platform_device_add()) must bump the reference of the of_node they
assign manually. Add the missing call to of_node_get().

Cc: stable@vger.kernel.org
Fixes: 76723bca2802 ("net: mv643xx_eth: add DT parsing support")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Resending separately as requested by Jakub

 drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index f9055b3d6fb10..1881583be5ce2 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -2780,7 +2780,7 @@ static int mv643xx_eth_shared_of_add_port(struct platform_device *pdev,
 		goto put_err;
 	}
 	ppdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
-	ppdev->dev.of_node = pnp;
+	ppdev->dev.of_node = of_node_get(pnp);
 
 	ret = platform_device_add_resources(ppdev, &res, 1);
 	if (ret)
-- 
2.47.3

Re: [PATCH RESEND net] net: mv643xx: fix OF node refcount

[Jakub Kicinski]

On Tue,  2 Jun 2026 09:34:14 +0200 Bartosz Golaszewski wrote:
> Platform devices created with platform_device_alloc() call
> platform_device_release() when the last reference to the device's
> kobject is dropped. This function calls of_node_put() unconditionally.
> This works fine for devices created with platform_device_register_full()
> but users of the split approach (platform_device_alloc() +
> platform_device_add()) must bump the reference of the of_node they
> assign manually. Add the missing call to of_node_get().

Where is it released? I think it's important to note, I can amend
the commit message if needed..

Re: [PATCH RESEND net] net: mv643xx: fix OF node refcount

[Jakub Kicinski]

On Thu, 4 Jun 2026 08:34:30 -0700 Jakub Kicinski wrote:
> On Tue,  2 Jun 2026 09:34:14 +0200 Bartosz Golaszewski wrote:
> > Platform devices created with platform_device_alloc() call
> > platform_device_release() when the last reference to the device's
> > kobject is dropped. This function calls of_node_put() unconditionally.
> > This works fine for devices created with platform_device_register_full()
> > but users of the split approach (platform_device_alloc() +
> > platform_device_add()) must bump the reference of the of_node they
> > assign manually. Add the missing call to of_node_get().  
> 
> Where is it released? I think it's important to note, I can amend
> the commit message if needed..

Not enough coffee in the morning I guess.

Re: [PATCH RESEND net] net: mv643xx: fix OF node refcount

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  2 Jun 2026 09:34:14 +0200 you wrote:
> Platform devices created with platform_device_alloc() call
> platform_device_release() when the last reference to the device's
> kobject is dropped. This function calls of_node_put() unconditionally.
> This works fine for devices created with platform_device_register_full()
> but users of the split approach (platform_device_alloc() +
> platform_device_add()) must bump the reference of the of_node they
> assign manually. Add the missing call to of_node_get().
> 
> [...]

Here is the summary with links:
  - [RESEND,net] net: mv643xx: fix OF node refcount
    https://git.kernel.org/netdev/net/c/4aacf509e537

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html