* [PATCH net-next] selftests: net: do not detect PPPoX loopback
@ 2026-06-03 6:17 Qingfang Deng
2026-06-06 0:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Qingfang Deng @ 2026-06-03 6:17 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Shuah Khan, Qingfang Deng, linux-ppp, netdev,
linux-kselftest, linux-kernel
Cc: Matthieu Baerts
By default, pppd attempts to detect loopbacks on the underlying
interface using a pseudo-randomly generated magic number and checks if
the same value is received. The seed for the PRNG is a hash of hostname
XOR current time XOR pid, which is likely to collide on NIPA, causing
false positives. Disable magic number generation.
Reported-by: Matthieu Baerts <matttbe@kernel.org>
Fixes: 7af2a94f4dcf ("selftests: net: add tests for PPPoL2TP")
Signed-off-by: Qingfang Deng <qingfang.deng@linux.dev>
---
tools/testing/selftests/net/ppp/pppoe-server-options | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/ppp/pppoe-server-options b/tools/testing/selftests/net/ppp/pppoe-server-options
index 66c8c9d319e9..cd586be7061b 100644
--- a/tools/testing/selftests/net/ppp/pppoe-server-options
+++ b/tools/testing/selftests/net/ppp/pppoe-server-options
@@ -1,2 +1,3 @@
noauth
noipdefault
+nomagic
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] selftests: net: do not detect PPPoX loopback
2026-06-03 6:17 [PATCH net-next] selftests: net: do not detect PPPoX loopback Qingfang Deng
@ 2026-06-06 0:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-06 0:40 UTC (permalink / raw)
To: Qingfang Deng
Cc: davem, edumazet, kuba, pabeni, horms, shuah, linux-ppp, netdev,
linux-kselftest, linux-kernel, matttbe
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 3 Jun 2026 14:17:44 +0800 you wrote:
> By default, pppd attempts to detect loopbacks on the underlying
> interface using a pseudo-randomly generated magic number and checks if
> the same value is received. The seed for the PRNG is a hash of hostname
> XOR current time XOR pid, which is likely to collide on NIPA, causing
> false positives. Disable magic number generation.
>
> Reported-by: Matthieu Baerts <matttbe@kernel.org>
> Fixes: 7af2a94f4dcf ("selftests: net: add tests for PPPoL2TP")
> Signed-off-by: Qingfang Deng <qingfang.deng@linux.dev>
>
> [...]
Here is the summary with links:
- [net-next] selftests: net: do not detect PPPoX loopback
https://git.kernel.org/netdev/net-next/c/2eb9a81a7f73
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-06 0:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-03 6:17 [PATCH net-next] selftests: net: do not detect PPPoX loopback Qingfang Deng
2026-06-06 0:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox