* [PATCH v2,net] net: ena: PHC: Add missing barrier
@ 2026-06-04 8:07 Arthur Kiyanovski
2026-06-06 1:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Arthur Kiyanovski @ 2026-06-04 8:07 UTC (permalink / raw)
To: David Miller, Jakub Kicinski, netdev
Cc: Arthur Kiyanovski, Eric Dumazet, Paolo Abeni, David Woodhouse,
Zorik Machulsky, Alexander Matushevsky, Saeed Bshara, Matt Wilson,
Anthony Liguori, Nafea Bshara, Evgeny Schmeilin, Netanel Belgazal,
Ali Saidi, Benjamin Herrenschmidt, Noam Dagan, David Arinzon,
Evgeny Ostrovsky, Ofir Tabachnik, Amit Bernstein, Andrew Lunn,
Saeed Bishara, linux-kernel
Add dma_rmb() barrier after req_id completion check in
ena_com_phc_get_timestamp(). On weakly-ordered architectures,
payload fields may be read before req_id is observed as updated.
Fixes: e0ea34158ee8 ("net: ena: Add PHC support in the ENA driver")
Closes: https://sashiko.dev/#/patchset/20260430032507.11586-1-akiyano%40amazon.com
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
---
drivers/net/ethernet/amazon/ena/ena_com.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
index 8c86789d867a..297fb36ab8c1 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_com.c
@@ -1880,6 +1880,11 @@ int ena_com_phc_get_timestamp(struct ena_com_dev *ena_dev, u64 *timestamp)
continue;
}
+ /* Ensure PHC payload (timestamp, error_flags) is read
+ * after req_id update is observed
+ */
+ dma_rmb();
+
/* req_id was updated by the device which indicates that
* PHC timestamp and error_flags are updated too,
* checking errors before retrieving timestamp
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2,net] net: ena: PHC: Add missing barrier
2026-06-04 8:07 [PATCH v2,net] net: ena: PHC: Add missing barrier Arthur Kiyanovski
@ 2026-06-06 1:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-06 1:50 UTC (permalink / raw)
To: Arthur Kiyanovski
Cc: davem, kuba, netdev, edumazet, pabeni, dwmw, zorik, matua, saeedb,
msw, aliguori, nafea, evgenys, netanel, alisaidi, benh, ndagan,
darinzon, evostrov, ofirt, amitbern, andrew+netdev,
saeed.bishara.os, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 4 Jun 2026 08:07:04 +0000 you wrote:
> Add dma_rmb() barrier after req_id completion check in
> ena_com_phc_get_timestamp(). On weakly-ordered architectures,
> payload fields may be read before req_id is observed as updated.
>
> Fixes: e0ea34158ee8 ("net: ena: Add PHC support in the ENA driver")
> Closes: https://sashiko.dev/#/patchset/20260430032507.11586-1-akiyano%40amazon.com
> Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
>
> [...]
Here is the summary with links:
- [v2,net] net: ena: PHC: Add missing barrier
https://git.kernel.org/netdev/net/c/954981dbbfbd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-06 1:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-04 8:07 [PATCH v2,net] net: ena: PHC: Add missing barrier Arthur Kiyanovski
2026-06-06 1:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox