Netdev List
 help / color / mirror / Atom feed
* [PATCH 1/2 iproute2-next] man: iplink: fix indentation level after inet parameter
@ 2026-06-07  6:57 Fernando Fernandez Mancera
  2026-06-07  6:57 ` [PATCH 2/2 iproute2-next] iplink: set NLA_F_NESTED for IPv4 devconf attributes Fernando Fernandez Mancera
  2026-06-07 13:50 ` [PATCH 1/2 iproute2-next] man: iplink: fix indentation level after inet parameter patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Fernando Fernandez Mancera @ 2026-06-07  6:57 UTC (permalink / raw)
  To: netdev; +Cc: dsahern, stephen, davem, kuba, pabeni, Fernando Fernandez Mancera

The indentation for inet block opens with +8 but closes with -10. Fix
the imbalance.

Fixes: fdb064bf64e5 ("iplink: add support for setting IPv4 devconf parameters")
Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
---
 man/man8/ip-link.8.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index e7ef64dd..d4f9f062 100644
--- a/man/man8/ip-link.8.in
+++ b/man/man8/ip-link.8.in
@@ -214,7 +214,7 @@ ip-link \- network device configuration
 .br
 .RB "[ " igmpv3_unsolicited_report_interval " " INTERVAL " ] ]"
 .br
-.in -10
+.in -8
 .br
 .RB "[ " macaddr
 .RI "[ " MACADDR " ]"
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2 iproute2-next] iplink: set NLA_F_NESTED for IPv4 devconf attributes
  2026-06-07  6:57 [PATCH 1/2 iproute2-next] man: iplink: fix indentation level after inet parameter Fernando Fernandez Mancera
@ 2026-06-07  6:57 ` Fernando Fernandez Mancera
  2026-06-07 13:50 ` [PATCH 1/2 iproute2-next] man: iplink: fix indentation level after inet parameter patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Fernando Fernandez Mancera @ 2026-06-07  6:57 UTC (permalink / raw)
  To: netdev; +Cc: dsahern, stephen, davem, kuba, pabeni, Fernando Fernandez Mancera

In order to use set multiple IPv4 devconf parameters at once,
NLA_F_NESTED flag is required.

ip link set dev enp8s0 inet forwarding on proxy_arp off

Fixes: fdb064bf64e5 ("iplink: add support for setting IPv4 devconf parameters")
Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
---
 ip/iplink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ip/iplink.c b/ip/iplink.c
index 9799530f..3f0b46c9 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -579,7 +579,8 @@ static int iplink_parse_inet(int *argcp, char ***argvp, struct iplink_req *req)
 
 	afs = addattr_nest(&req->n, sizeof(*req), IFLA_AF_SPEC);
 	afinet = addattr_nest(&req->n, sizeof(*req), AF_INET);
-	inet_devconf = addattr_nest(&req->n, sizeof(*req), IFLA_INET_CONF);
+	inet_devconf = addattr_nest(&req->n, sizeof(*req),
+				    IFLA_INET_CONF | NLA_F_NESTED);
 
 	while (NEXT_ARG_OK()) {
 		NEXT_ARG();
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2 iproute2-next] man: iplink: fix indentation level after inet parameter
  2026-06-07  6:57 [PATCH 1/2 iproute2-next] man: iplink: fix indentation level after inet parameter Fernando Fernandez Mancera
  2026-06-07  6:57 ` [PATCH 2/2 iproute2-next] iplink: set NLA_F_NESTED for IPv4 devconf attributes Fernando Fernandez Mancera
@ 2026-06-07 13:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-07 13:50 UTC (permalink / raw)
  To: Fernando Fernandez Mancera; +Cc: netdev, dsahern, stephen, davem, kuba, pabeni

Hello:

This series was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:

On Sun,  7 Jun 2026 08:57:14 +0200 you wrote:
> The indentation for inet block opens with +8 but closes with -10. Fix
> the imbalance.
> 
> Fixes: fdb064bf64e5 ("iplink: add support for setting IPv4 devconf parameters")
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
> ---
>  man/man8/ip-link.8.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [1/2,iproute2-next] man: iplink: fix indentation level after inet parameter
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=6592993853c0
  - [2/2,iproute2-next] iplink: set NLA_F_NESTED for IPv4 devconf attributes
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=7340b539841d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-07 13:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-07  6:57 [PATCH 1/2 iproute2-next] man: iplink: fix indentation level after inet parameter Fernando Fernandez Mancera
2026-06-07  6:57 ` [PATCH 2/2 iproute2-next] iplink: set NLA_F_NESTED for IPv4 devconf attributes Fernando Fernandez Mancera
2026-06-07 13:50 ` [PATCH 1/2 iproute2-next] man: iplink: fix indentation level after inet parameter patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox