* [net-next v1] net: ncsi: Set ncsi_stop_dev() to inline while NET_NCSI not enabled
@ 2026-06-05 3:36 Minda Chen
2026-06-10 0:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Minda Chen @ 2026-06-05 3:36 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, netdev
Cc: linux-kernel, Minda Chen
While NET_NCSI not enabled, ncsi_stop_dev() is not inline
and call with it, casue compile waring:
linux/include/net/ncsi.h:63:13: warning: 'ncsi_stop_dev'
defined but not used [-Wunused-function]
static void ncsi_stop_dev(struct ncsi_dev *nd)
Setting ncsi_stop_dev() to inline like other function to
remove compile warnings.
Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
---
include/net/ncsi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/ncsi.h b/include/net/ncsi.h
index 08a50d9acb0a..e886358207aa 100644
--- a/include/net/ncsi.h
+++ b/include/net/ncsi.h
@@ -60,7 +60,7 @@ static inline int ncsi_start_dev(struct ncsi_dev *nd)
return -ENOTTY;
}
-static void ncsi_stop_dev(struct ncsi_dev *nd)
+static inline void ncsi_stop_dev(struct ncsi_dev *nd)
{
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next v1] net: ncsi: Set ncsi_stop_dev() to inline while NET_NCSI not enabled
2026-06-05 3:36 [net-next v1] net: ncsi: Set ncsi_stop_dev() to inline while NET_NCSI not enabled Minda Chen
@ 2026-06-10 0:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-10 0:40 UTC (permalink / raw)
To: Minda Chen; +Cc: davem, edumazet, kuba, pabeni, horms, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 5 Jun 2026 11:36:07 +0800 you wrote:
> While NET_NCSI not enabled, ncsi_stop_dev() is not inline
> and call with it, casue compile waring:
>
> linux/include/net/ncsi.h:63:13: warning: 'ncsi_stop_dev'
> defined but not used [-Wunused-function]
> static void ncsi_stop_dev(struct ncsi_dev *nd)
>
> [...]
Here is the summary with links:
- [net-next,v1] net: ncsi: Set ncsi_stop_dev() to inline while NET_NCSI not enabled
https://git.kernel.org/netdev/net-next/c/5c9a6a124afd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-10 0:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-05 3:36 [net-next v1] net: ncsi: Set ncsi_stop_dev() to inline while NET_NCSI not enabled Minda Chen
2026-06-10 0:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox