* [PATCH] net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option
@ 2026-06-09 4:52 Ethan Nelson-Moore
2026-06-10 10:53 ` Wei Fang
2026-06-11 22:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-09 4:52 UTC (permalink / raw)
To: netdev
Cc: Ethan Nelson-Moore, Wei Fang, Frank Li, Shenwei Wang, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
The CONFIG_GILBARCONAP option has never been defined by the kernel, but
is referred to by drivers/net/ethernet/freescale/fec_main.c. Remove this
reference to eliminate dead code.
Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 6ebde65d7f1b..ced4dbf8cd90 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -218,7 +218,7 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address");
*/
#if defined(CONFIG_NETtel)
#define FEC_FLASHMAC 0xf0006006
-#elif defined(CONFIG_GILBARCONAP) || defined(CONFIG_SCALES)
+#elif defined(CONFIG_SCALES)
#define FEC_FLASHMAC 0xf0006000
#elif defined(CONFIG_CANCam)
#define FEC_FLASHMAC 0xf0020000
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option
2026-06-09 4:52 [PATCH] net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option Ethan Nelson-Moore
@ 2026-06-10 10:53 ` Wei Fang
2026-06-11 22:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Wei Fang @ 2026-06-10 10:53 UTC (permalink / raw)
To: Ethan Nelson-Moore, netdev@vger.kernel.org
Cc: Frank Li, Shenwei Wang, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
> The CONFIG_GILBARCONAP option has never been defined by the kernel, but
> is referred to by drivers/net/ethernet/freescale/fec_main.c. Remove this
> reference to eliminate dead code.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 6ebde65d7f1b..ced4dbf8cd90 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -218,7 +218,7 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC
> address");
> */
> #if defined(CONFIG_NETtel)
> #define FEC_FLASHMAC 0xf0006006
> -#elif defined(CONFIG_GILBARCONAP) || defined(CONFIG_SCALES)
> +#elif defined(CONFIG_SCALES)
> #define FEC_FLASHMAC 0xf0006000
> #elif defined(CONFIG_CANCam)
> #define FEC_FLASHMAC 0xf0020000
> --
> 2.43.0
Reviewed-by: Wei Fang <wei.fang@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option
2026-06-09 4:52 [PATCH] net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option Ethan Nelson-Moore
2026-06-10 10:53 ` Wei Fang
@ 2026-06-11 22:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-11 22:30 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: netdev, wei.fang, frank.li, shenwei.wang, andrew+netdev, davem,
edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 8 Jun 2026 21:52:00 -0700 you wrote:
> The CONFIG_GILBARCONAP option has never been defined by the kernel, but
> is referred to by drivers/net/ethernet/freescale/fec_main.c. Remove this
> reference to eliminate dead code.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> [...]
Here is the summary with links:
- net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option
https://git.kernel.org/netdev/net-next/c/f8142f5578b4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-11 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-09 4:52 [PATCH] net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option Ethan Nelson-Moore
2026-06-10 10:53 ` Wei Fang
2026-06-11 22:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox