[PATCH net-next] ptp: ocp: add shutdown callback

[PATCH net-next] ptp: ocp: add shutdown callback

[Vadim Fedorenko]

The shutdown callback was never implemented for this driver, but it's
needed because .remove() callback is never called during kexec/reboot
process. That leaves HW with some interrupts enabled and may cause
spurious interrupt while booting into a new kernel during with kexec.
If it happens that I2C interrupt fires during kexec, the whole I2C bus
is disabled leaving TimeCard with no devlink communication. The same
happens if timestampers were enabled, leaving the card without
timestamper interrupts until full reboot cycle.

Implement .shutdown() callback with the same function as remove
callback.

Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
---
 drivers/ptp/ptp_ocp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index beacc2ffb166..3465cb7f3311 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -5171,6 +5171,7 @@ static struct pci_driver ptp_ocp_driver = {
 	.id_table	= ptp_ocp_pcidev_id,
 	.probe		= ptp_ocp_probe,
 	.remove		= ptp_ocp_remove,
+	.shutdown	= ptp_ocp_remove,
 };
 
 static int
-- 
2.47.3

Re: [PATCH net-next] ptp: ocp: add shutdown callback

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 11 Jun 2026 19:03:33 +0000 you wrote:
> The shutdown callback was never implemented for this driver, but it's
> needed because .remove() callback is never called during kexec/reboot
> process. That leaves HW with some interrupts enabled and may cause
> spurious interrupt while booting into a new kernel during with kexec.
> If it happens that I2C interrupt fires during kexec, the whole I2C bus
> is disabled leaving TimeCard with no devlink communication. The same
> happens if timestampers were enabled, leaving the card without
> timestamper interrupts until full reboot cycle.
> 
> [...]

Here is the summary with links:
  - [net-next] ptp: ocp: add shutdown callback
    https://git.kernel.org/netdev/net-next/c/f6f955cbf9d4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html