Netdev List
 help / color / mirror / Atom feed
* [PATCH net] net/sched: sch_dualpi2: Add missing module alias
@ 2026-06-11 20:58 Victor Nogueira
  2026-06-11 21:54 ` Pedro Tammela
  2026-06-13  1:10 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Victor Nogueira @ 2026-06-11 20:58 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, jhs, jiri, horms
  Cc: netdev, pctammela, chia-yu.chang

When a qdisc is added by name, the kernel tries to autoload its module
via request_qdisc_module(), which calls:

request_module(NET_SCH_ALIAS_PREFIX "%s", name);

i.e. it asks modprobe to resolve the "net-sch-<kind>" alias (e.g.
"net-sch-dualpi2") rather than the module's file name. Since dualpi2
was shipped without this alias, the autoload fails:

tc qdisc add dev lo root handle 1: dualpi2
Error: Specified qdisc kind is unknown.

Fix this by adding the missing alias so the qdisc is autoloaded on demand
like the others.

Fixes: 320d031ad6e4 ("sched: Struct definition and parsing of dualpi2 qdisc")
Signed-off-by: Victor Nogueira <victor@mojatatu.com>
---
 net/sched/sch_dualpi2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sched/sch_dualpi2.c b/net/sched/sch_dualpi2.c
index a22489c14458..65d0f4036efa 100644
--- a/net/sched/sch_dualpi2.c
+++ b/net/sched/sch_dualpi2.c
@@ -1174,6 +1174,7 @@ static struct Qdisc_ops dualpi2_qdisc_ops __read_mostly = {
 	.dump_stats	= dualpi2_dump_stats,
 	.owner		= THIS_MODULE,
 };
+MODULE_ALIAS_NET_SCH("dualpi2");
 
 static int __init dualpi2_module_init(void)
 {
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net/sched: sch_dualpi2: Add missing module alias
  2026-06-11 20:58 [PATCH net] net/sched: sch_dualpi2: Add missing module alias Victor Nogueira
@ 2026-06-11 21:54 ` Pedro Tammela
  2026-06-13  1:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Pedro Tammela @ 2026-06-11 21:54 UTC (permalink / raw)
  To: Victor Nogueira, davem, edumazet, kuba, pabeni, jhs, jiri, horms
  Cc: netdev, chia-yu.chang

On 11/06/2026 17:58, Victor Nogueira wrote:
> When a qdisc is added by name, the kernel tries to autoload its module
> via request_qdisc_module(), which calls:
> 
> request_module(NET_SCH_ALIAS_PREFIX "%s", name);
> 
> i.e. it asks modprobe to resolve the "net-sch-<kind>" alias (e.g.
> "net-sch-dualpi2") rather than the module's file name. Since dualpi2
> was shipped without this alias, the autoload fails:
> 
> tc qdisc add dev lo root handle 1: dualpi2
> Error: Specified qdisc kind is unknown.
> 
> Fix this by adding the missing alias so the qdisc is autoloaded on demand
> like the others.
> 
> Fixes: 320d031ad6e4 ("sched: Struct definition and parsing of dualpi2 qdisc")
> Signed-off-by: Victor Nogueira <victor@mojatatu.com>

Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>

> ---
>   net/sched/sch_dualpi2.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/net/sched/sch_dualpi2.c b/net/sched/sch_dualpi2.c
> index a22489c14458..65d0f4036efa 100644
> --- a/net/sched/sch_dualpi2.c
> +++ b/net/sched/sch_dualpi2.c
> @@ -1174,6 +1174,7 @@ static struct Qdisc_ops dualpi2_qdisc_ops __read_mostly = {
>   	.dump_stats	= dualpi2_dump_stats,
>   	.owner		= THIS_MODULE,
>   };
> +MODULE_ALIAS_NET_SCH("dualpi2");
>   
>   static int __init dualpi2_module_init(void)
>   {


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net/sched: sch_dualpi2: Add missing module alias
  2026-06-11 20:58 [PATCH net] net/sched: sch_dualpi2: Add missing module alias Victor Nogueira
  2026-06-11 21:54 ` Pedro Tammela
@ 2026-06-13  1:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-13  1:10 UTC (permalink / raw)
  To: Victor Nogueira
  Cc: davem, edumazet, kuba, pabeni, jhs, jiri, horms, netdev,
	pctammela, chia-yu.chang

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 11 Jun 2026 17:58:49 -0300 you wrote:
> When a qdisc is added by name, the kernel tries to autoload its module
> via request_qdisc_module(), which calls:
> 
> request_module(NET_SCH_ALIAS_PREFIX "%s", name);
> 
> i.e. it asks modprobe to resolve the "net-sch-<kind>" alias (e.g.
> "net-sch-dualpi2") rather than the module's file name. Since dualpi2
> was shipped without this alias, the autoload fails:
> 
> [...]

Here is the summary with links:
  - [net] net/sched: sch_dualpi2: Add missing module alias
    https://git.kernel.org/netdev/net/c/ee1ba0add3fb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-13  1:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-11 20:58 [PATCH net] net/sched: sch_dualpi2: Add missing module alias Victor Nogueira
2026-06-11 21:54 ` Pedro Tammela
2026-06-13  1:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox