Netdev List
 help / color / mirror / Atom feed
* [PATCH net-next] selftests: net: Add a missing config option
@ 2026-07-23 14:02 Alice Mikityanska
  2026-07-27  9:09 ` Matthieu Baerts
  2026-07-28  1:10 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Alice Mikityanska @ 2026-07-23 14:02 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: Eric Dumazet, David S. Miller, Paolo Abeni, Simon Horman,
	Shuah Khan, netdev, linux-kselftest, Alice Mikityanska

From: Alice Mikityanska <alice@isovalent.com>

Commit 5cb53743e1ff ("selftests: net: Add a test for BIG TCP in UDP
tunnels") used iptables match comment, which was missed from the CI
kernel config. Add the missing config option.

Signed-off-by: Alice Mikityanska <alice@isovalent.com>
---
 tools/testing/selftests/net/config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index 96fffca6547c..a2d14ec9df1a 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config
@@ -82,6 +82,7 @@ CONFIG_NETFILTER=y
 CONFIG_NETFILTER_ADVANCED=y
 CONFIG_NETFILTER_XTABLES_LEGACY=y
 CONFIG_NETFILTER_XT_MATCH_BPF=m
+CONFIG_NETFILTER_XT_MATCH_COMMENT=y
 CONFIG_NETFILTER_XT_MATCH_LENGTH=m
 CONFIG_NETFILTER_XT_MATCH_POLICY=m
 CONFIG_NETFILTER_XT_NAT=m
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] selftests: net: Add a missing config option
  2026-07-23 14:02 [PATCH net-next] selftests: net: Add a missing config option Alice Mikityanska
@ 2026-07-27  9:09 ` Matthieu Baerts
  2026-07-28  1:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Matthieu Baerts @ 2026-07-27  9:09 UTC (permalink / raw)
  To: Alice Mikityanska, Jakub Kicinski
  Cc: Eric Dumazet, David S. Miller, Paolo Abeni, Simon Horman,
	Shuah Khan, netdev, linux-kselftest, Alice Mikityanska

Hi Alice,

On 23/07/2026 16:02, Alice Mikityanska wrote:
> From: Alice Mikityanska <alice@isovalent.com>
> 
> Commit 5cb53743e1ff ("selftests: net: Add a test for BIG TCP in UDP
> tunnels") used iptables match comment, which was missed from the CI
> kernel config. Add the missing config option.

It helps, the CI can now run this test!

Reviewed-by: Matthieu Baerts <matttbe@kernel.org>


But I think another follow-up patch is required, because this test is
flaky when using a debug kernel config:


https://netdev.bots.linux.dev/flakes.html?min-flip=0&tn-needle=big-tcp-tunnels-sh

Maybe because wait_local_port_listen() is required after having called
netserver?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] selftests: net: Add a missing config option
  2026-07-23 14:02 [PATCH net-next] selftests: net: Add a missing config option Alice Mikityanska
  2026-07-27  9:09 ` Matthieu Baerts
@ 2026-07-28  1:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-07-28  1:10 UTC (permalink / raw)
  To: Alice Mikityanska
  Cc: kuba, edumazet, davem, pabeni, horms, shuah, netdev,
	linux-kselftest, alice

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 23 Jul 2026 17:02:41 +0300 you wrote:
> From: Alice Mikityanska <alice@isovalent.com>
> 
> Commit 5cb53743e1ff ("selftests: net: Add a test for BIG TCP in UDP
> tunnels") used iptables match comment, which was missed from the CI
> kernel config. Add the missing config option.
> 
> Signed-off-by: Alice Mikityanska <alice@isovalent.com>
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: net: Add a missing config option
    https://git.kernel.org/netdev/net-next/c/8fe79aa2f1d6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-28  1:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 14:02 [PATCH net-next] selftests: net: Add a missing config option Alice Mikityanska
2026-07-27  9:09 ` Matthieu Baerts
2026-07-28  1:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox