* [PATCH net-next v2] wanxl: Remove pci_map_single_debug()
@ 2026-07-27 14:02 Bence Csokas
2026-07-30 23:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Bence Csokas @ 2026-07-27 14:02 UTC (permalink / raw)
To: Krzysztof Halasa, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel
Cc: Bence Csokas, Simon Horman
Since commit 24dd377a76b0 ("wan: wanxl: switch from 'pci_' to 'dma_' API")
this has been dead code anyways. The pci_map_single() function it attempts
to redefine has been removed in commit 7968778914e5 ("PCI: Remove the
deprecated "pci-dma-compat.h" API").
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/all/20260709151401.GO1364329@horms.kernel.org
Signed-off-by: Bence Csokas <bence.csokas@arm.com>
---
Changes in v2:
- Remove now-unused DEBUG_PCI macro
- Collect Simon's tag
- Link to v1: https://patch.msgid.link/20260703-wanxl-cleanup-v1-1-d5deb23fa941@arm.com
---
drivers/net/wan/wanxl.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index 065c00c12cc1..c9873f07e06c 100644
--- a/drivers/net/wan/wanxl.c
+++ b/drivers/net/wan/wanxl.c
@@ -37,7 +37,6 @@ static const char *version = "wanXL serial card driver version: 0.48";
#define PLX_CTL_RESET 0x40000000 /* adapter reset */
#undef DEBUG_PKT
-#undef DEBUG_PCI
/* MAILBOX #1 - PUTS COMMANDS */
#define MBX1_CMD_ABORTJ 0x85000000 /* Abort and Jump */
@@ -88,22 +87,6 @@ static inline port_status_t *get_status(struct port *port)
return &port->card->status->port_status[port->node];
}
-#ifdef DEBUG_PCI
-static inline dma_addr_t pci_map_single_debug(struct pci_dev *pdev, void *ptr,
- size_t size, int direction)
-{
- dma_addr_t addr = dma_map_single(&pdev->dev, ptr, size, direction);
-
- if (addr + size > 0x100000000LL)
- pr_crit("%s: pci_map_single() returned memory at 0x%llx!\n",
- pci_name(pdev), (unsigned long long)addr);
- return addr;
-}
-
-#undef pci_map_single
-#define pci_map_single pci_map_single_debug
-#endif
-
/* Cable and/or personality module change interrupt service */
static inline void wanxl_cable_intr(struct port *port)
{
---
base-commit: f5098b6bae761e346ebcd9da7f95622c04733cff
change-id: 20260427-wanxl-cleanup-7e59607dc4f9
Best regards,
--
Bence Csokas <bence.csokas@arm.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next v2] wanxl: Remove pci_map_single_debug()
2026-07-27 14:02 [PATCH net-next v2] wanxl: Remove pci_map_single_debug() Bence Csokas
@ 2026-07-30 23:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-07-30 23:20 UTC (permalink / raw)
To: Bence Csokas
Cc: khc, andrew+netdev, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, horms
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 27 Jul 2026 16:02:07 +0200 you wrote:
> Since commit 24dd377a76b0 ("wan: wanxl: switch from 'pci_' to 'dma_' API")
> this has been dead code anyways. The pci_map_single() function it attempts
> to redefine has been removed in commit 7968778914e5 ("PCI: Remove the
> deprecated "pci-dma-compat.h" API").
>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Link: https://lore.kernel.org/all/20260709151401.GO1364329@horms.kernel.org
> Signed-off-by: Bence Csokas <bence.csokas@arm.com>
>
> [...]
Here is the summary with links:
- [net-next,v2] wanxl: Remove pci_map_single_debug()
https://git.kernel.org/netdev/net-next/c/8e4d7d120734
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-30 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-27 14:02 [PATCH net-next v2] wanxl: Remove pci_map_single_debug() Bence Csokas
2026-07-30 23:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox