* [PATCH net-next v2] selftests: drv-net: hide the devlink port_split test
@ 2026-08-11 0:46 Jakub Kicinski
2026-08-12 1:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2026-08-11 0:46 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
Petr Machata, danieller, shuah, linux-kselftest
The devlink port_split test has limited applicability.
NICs (as opposed to switches) require at least a re-probe
to apply the split configuration.
On top of that the test is not compatible with our driver env,
it just splits all ports on the system, not only what NETIF
points at.
Long term we may want to add some indication in devlink whether
the port splitting is runtime (cmode of sorts), and fix the
test to follow driver env. But since no (known) NIC driver can
support runtime anyway let's just hide the test from the selftest
framework by moving it to extra files.
Having this test randomly break unrelated NICs within the DUT
makes people implement allow-lists for ksft, which then means
their setups don't run new tests. It's very useful during test
review to see whether the test works across all the runners.
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
v2:
- use TEST_PROGS_EXTENDED instead of TEST_FILES
v1: https://lore.kernel.org/20260808164843.2475226-1-kuba@kernel.org
CC: danieller@nvidia.com
CC: petrm@nvidia.com
CC: shuah@kernel.org
CC: linux-kselftest@vger.kernel.org
---
tools/testing/selftests/drivers/net/hw/Makefile | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/hw/Makefile b/tools/testing/selftests/drivers/net/hw/Makefile
index 234db5c2c90c..78bb0169350b 100644
--- a/tools/testing/selftests/drivers/net/hw/Makefile
+++ b/tools/testing/selftests/drivers/net/hw/Makefile
@@ -19,7 +19,6 @@ TEST_GEN_FILES := \
TEST_PROGS = \
csum.py \
- devlink_port_split.py \
devlink_rate_cross_esw.py \
devlink_rate_tc_bw.py \
devmem.py \
@@ -54,6 +53,10 @@ TEST_PROGS = \
xsk_reconfig.py \
#
+TEST_PROGS_EXTENDED := \
+ devlink_port_split.py \
+# end of TEST_PROGS_EXTENDED
+
TEST_FILES := \
devmem_lib.py \
ethtool_lib.sh \
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] selftests: drv-net: hide the devlink port_split test
2026-08-11 0:46 [PATCH net-next v2] selftests: drv-net: hide the devlink port_split test Jakub Kicinski
@ 2026-08-12 1:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-08-12 1:40 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms, petrm,
danieller, shuah, linux-kselftest
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 10 Aug 2026 17:46:45 -0700 you wrote:
> The devlink port_split test has limited applicability.
> NICs (as opposed to switches) require at least a re-probe
> to apply the split configuration.
>
> On top of that the test is not compatible with our driver env,
> it just splits all ports on the system, not only what NETIF
> points at.
>
> [...]
Here is the summary with links:
- [net-next,v2] selftests: drv-net: hide the devlink port_split test
https://git.kernel.org/netdev/net-next/c/878b56de01e2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-12 1:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-11 0:46 [PATCH net-next v2] selftests: drv-net: hide the devlink port_split test Jakub Kicinski
2026-08-12 1:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox