[PATCH net-next] net: psp: use psp_dev_is_registered() in psp_assoc_free()

[PATCH net-next] net: psp: use psp_dev_is_registered() in psp_assoc_free()

[Daniel Zahka]

No functional changes.

In code paths that use a psp_dev reference that wasn't obtained from
the psp_devs xarray, e.g. not via psp_device_get_and_lock(), there is
no guarantee that the psp_dev has not been unregistered. The check
here is correct, but it doesn't match other code paths that use
psp_dev_is_registered().

Commit b89769f936a8 ("net: psp: check for device unregister when
creating assoc") is an example of a fix that adds a check for this
after locking a psp_dev. if (psp_dev_is_registered(psd)) vs if
(psd->ops) makes it clear what we are really checking for.

Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>
---
 net/psp/psp_sock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/psp/psp_sock.c b/net/psp/psp_sock.c
index 07dc4cf741f3..1a2a6b7516b0 100644
--- a/net/psp/psp_sock.c
+++ b/net/psp/psp_sock.c
@@ -96,7 +96,7 @@ static void psp_assoc_free(struct work_struct *work)
 	struct psp_dev *psd = pas->psd;
 
 	mutex_lock(&psd->lock);
-	if (psd->ops)
+	if (psp_dev_is_registered(psd))
 		psp_dev_tx_key_del(psd, pas);
 	mutex_unlock(&psd->lock);
 	psp_dev_put(psd);

---
base-commit: 4f93b12cf7b25fbf8e73d222722805b049f0a6d3
change-id: 20260814-psp-dev-is-reg-21bc63648558

Best regards,
-- 
Daniel Zahka <daniel.zahka@gmail.com>

Re: [PATCH net-next] net: psp: use psp_dev_is_registered() in psp_assoc_free()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 14 Aug 2026 04:44:06 -0700 you wrote:
> No functional changes.
> 
> In code paths that use a psp_dev reference that wasn't obtained from
> the psp_devs xarray, e.g. not via psp_device_get_and_lock(), there is
> no guarantee that the psp_dev has not been unregistered. The check
> here is correct, but it doesn't match other code paths that use
> psp_dev_is_registered().
> 
> [...]

Here is the summary with links:
  - [net-next] net: psp: use psp_dev_is_registered() in psp_assoc_free()
    https://git.kernel.org/netdev/net-next/c/cf85f810f911

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html