Netdev List
 help / color / mirror / Atom feed
* [PATCH net-next] net: ipa: Drop the monitor_rx endpoint_id ABI entry
@ 2026-09-05  9:27 Karl Mehltretter
  2026-09-08 12:49 ` Simon Horman
  2026-09-09  0:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Karl Mehltretter @ 2026-09-05  9:27 UTC (permalink / raw)
  To: Alex Elder
  Cc: Karl Mehltretter, Andrew Lunn, Jakub Kicinski, Eric Dumazet,
	Paolo Abeni, netdev

The ABI file documents .../endpoint_id/monitor_rx, but
drivers/net/ipa/ipa_sysfs.c has only ever created modem_rx and modem_tx
in the endpoint_id group. No monitor endpoint attribute exists.

Drop the entry.

Fixes: d79e4164d0d5 ("net: ipa: add an endpoint device attribute group")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 .../ABI/testing/sysfs-devices-platform-soc-ipa     | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-devices-platform-soc-ipa b/Documentation/ABI/testing/sysfs-devices-platform-soc-ipa
index 364b1ba41242..3b3bae2369d4 100644
--- a/Documentation/ABI/testing/sysfs-devices-platform-soc-ipa
+++ b/Documentation/ABI/testing/sysfs-devices-platform-soc-ipa
@@ -75,20 +75,6 @@ Description:
 		the ID of the AP endpoint on which packets destined
 		for the embedded modem are sent.
 
-What:		.../XXXXXXX.ipa/endpoint_id/monitor_rx
-Date:		July 2022
-KernelVersion:	v5.19
-Contact:	Alex Elder <elder@kernel.org>
-Description:
-		The .../XXXXXXX.ipa/endpoint_id/monitor_rx file contains
-		the ID of the AP endpoint on which IPA "monitor" data is
-		received.  The monitor endpoint supplies replicas of
-		packets that enter the IPA hardware for processing.
-		Each replicated packet is preceded by a fixed-size "ODL"
-		header (see .../XXXXXXX.ipa/feature/monitor, above).
-		Large packets are truncated, to reduce the bandwidth
-		required to provide the monitor function.
-
 What:		.../XXXXXXX.ipa/modem/
 Date:		June 2021
 KernelVersion:	v5.14
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: ipa: Drop the monitor_rx endpoint_id ABI entry
  2026-09-05  9:27 [PATCH net-next] net: ipa: Drop the monitor_rx endpoint_id ABI entry Karl Mehltretter
@ 2026-09-08 12:49 ` Simon Horman
  2026-09-09  0:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-09-08 12:49 UTC (permalink / raw)
  To: Karl Mehltretter
  Cc: Alex Elder, Andrew Lunn, Jakub Kicinski, Eric Dumazet,
	Paolo Abeni, netdev

On Sat, Sep 05, 2026 at 11:27:19AM +0200, Karl Mehltretter wrote:
> The ABI file documents .../endpoint_id/monitor_rx, but
> drivers/net/ipa/ipa_sysfs.c has only ever created modem_rx and modem_tx
> in the endpoint_id group. No monitor endpoint attribute exists.
> 
> Drop the entry.
> 
> Fixes: d79e4164d0d5 ("net: ipa: add an endpoint device attribute group")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: ipa: Drop the monitor_rx endpoint_id ABI entry
  2026-09-05  9:27 [PATCH net-next] net: ipa: Drop the monitor_rx endpoint_id ABI entry Karl Mehltretter
  2026-09-08 12:49 ` Simon Horman
@ 2026-09-09  0:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-09  0:40 UTC (permalink / raw)
  To: Karl Mehltretter; +Cc: elder, andrew+netdev, kuba, edumazet, pabeni, netdev

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat,  5 Sep 2026 11:27:19 +0200 you wrote:
> The ABI file documents .../endpoint_id/monitor_rx, but
> drivers/net/ipa/ipa_sysfs.c has only ever created modem_rx and modem_tx
> in the endpoint_id group. No monitor endpoint attribute exists.
> 
> Drop the entry.
> 
> Fixes: d79e4164d0d5 ("net: ipa: add an endpoint device attribute group")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: ipa: Drop the monitor_rx endpoint_id ABI entry
    https://git.kernel.org/netdev/net-next/c/548b86839f7f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-09  0:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-05  9:27 [PATCH net-next] net: ipa: Drop the monitor_rx endpoint_id ABI entry Karl Mehltretter
2026-09-08 12:49 ` Simon Horman
2026-09-09  0:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox